Mitaka to Newton upgrade - ovs 2.4 to 2.5 causes nodes to lose ovs interfaces

[Marios Andreou]

As first discussed in https://bugzilla.redhat.com/show_bug.cgi?id=1371840 during a node update (the bugzilla discusses upgrades but this can also apply to minor update) if OVS is being upgraded from 2.4 to 2.5 the post (yum) install restart causes OVS to lose interfaces

There is a workaround which we can use to special case this (force the rpm installation to not run the post install restart).

Patches incoming, filing the bug for now as we will need this in stable/newton

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/389114

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/389753

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/389114
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=7e09b70bc336b70be9042c8971ad020c6343d6c2
Submitter: Jenkins
Branch: master

commit 7e09b70bc336b70be9042c8971ad020c6343d6c2
Author: marios <email address hidden>
Date: Thu Oct 20 13:42:37 2016 +0300

    Add special case handling for OVS upgrade in updates and upgrades

    This adds a special case handling for the opensvswitch package
    as discussed at the related bug below.
    This is added/handled here for both the minor update and the
    major mitaka...newton upgrade.

    Change-Id: I9b1f0eaa0d36a28e20b507bec6a4e9b3af1781ae
    Closes-Bug: 1635205

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/389753
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=25268151502b90aa1648578fbf7dedae377221a2
Submitter: Jenkins
Branch: stable/newton

commit 25268151502b90aa1648578fbf7dedae377221a2
Author: marios <email address hidden>
Date: Thu Oct 20 13:42:37 2016 +0300

    Add special case handling for OVS upgrade in updates and upgrades

    This adds a special case handling for the opensvswitch package
    as discussed at the related bug below.
    This is added/handled here for both the minor update and the
    major mitaka...newton upgrade.

    Change-Id: I9b1f0eaa0d36a28e20b507bec6a4e9b3af1781ae
    Closes-Bug: 1635205
    (cherry picked from 7e09b70bc336b70be9042c8971ad020c6343d6c2)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/393688

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/393688
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=27163d00220c901d6d4e83b46d07b4bfaf3d33fd
Submitter: Jenkins
Branch: stable/mitaka

commit 27163d00220c901d6d4e83b46d07b4bfaf3d33fd
Author: marios <email address hidden>
Date: Thu Oct 20 13:42:37 2016 +0300

    Add special case handling for OVS upgrade in updates and upgrades

    This adds a special case handling for the opensvswitch package
    as discussed at the related bug below.
    This is added/handled here for both the minor update and the
    major mitaka...newton upgrade.

    Change-Id: I9b1f0eaa0d36a28e20b507bec6a4e9b3af1781ae
    Closes-Bug: 1635205
    (cherry picked from commit 25268151502b90aa1648578fbf7dedae377221a2)
    Conflicts:
     extraconfig/tasks/major_upgrade_ceph_storage.sh
     extraconfig/tasks/major_upgrade_controller_pacemaker_1.sh

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/397283

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 5.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 6.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/399708

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/400925

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/400925
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=5a472f196e3392bf4187d4498f7c50db596f360a
Submitter: Jenkins
Branch: master

commit 5a472f196e3392bf4187d4498f7c50db596f360a
Author: marios <email address hidden>
Date: Tue Nov 22 20:19:26 2016 +0200

    Fix ovs 2.4 to 2.5 upgrade - minor update non controllers

    In I9b1f0eaa0d36a28e20b507bec6a4e9b3af1781ae and
    I11fcf688982ceda5eef7afc8904afae44300c2d9 we landed a workaround
    for the openvswitch 2.4 to 2.5 upgrade discussed in the bug below.

    Unfortunately testing has revealed a problem with the minor update
    case specifically for non controllers. It seems we would exit
    before the ovs workaround has had a chance to execute. This moves
    the block up a few lines to avoid this condition. As with the
    other two reviews noted here, this will need to go into newton
    and then mitaka too.

    Change-Id: If905de82d96302334ebe02de9c43f00faed9b72b
    Related-Bug: 1635205

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/newton
Review: https://review.openstack.org/401195

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/401365

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/401195
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=33331d5849537cbfe838d9e8b5438aec1923332b
Submitter: Jenkins
Branch: stable/newton

commit 33331d5849537cbfe838d9e8b5438aec1923332b
Author: marios <email address hidden>
Date: Tue Nov 22 20:19:26 2016 +0200

    Fix ovs 2.4 to 2.5 upgrade - minor update non controllers

    In I9b1f0eaa0d36a28e20b507bec6a4e9b3af1781ae and
    I11fcf688982ceda5eef7afc8904afae44300c2d9 we landed a workaround
    for the openvswitch 2.4 to 2.5 upgrade discussed in the bug below.

    Unfortunately testing has revealed a problem with the minor update
    case specifically for non controllers. It seems we would exit
    before the ovs workaround has had a chance to execute. This moves
    the block up a few lines to avoid this condition. As with the
    other two reviews noted here, this will need to go into newton
    and then mitaka too.

    Change-Id: If905de82d96302334ebe02de9c43f00faed9b72b
    Related-Bug: 1635205
    (cherry picked from commit 5a472f196e3392bf4187d4498f7c50db596f360a)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/401365
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=097e3d9a0378ca95a2dbe8db82c698c8e41d21e5
Submitter: Jenkins
Branch: stable/mitaka

commit 097e3d9a0378ca95a2dbe8db82c698c8e41d21e5
Author: marios <email address hidden>
Date: Tue Nov 22 20:19:26 2016 +0200

    Fix ovs 2.4 to 2.5 upgrade - minor update non controllers

    In I9b1f0eaa0d36a28e20b507bec6a4e9b3af1781ae and
    I11fcf688982ceda5eef7afc8904afae44300c2d9 we landed a workaround
    for the openvswitch 2.4 to 2.5 upgrade discussed in the bug below.

    Unfortunately testing has revealed a problem with the minor update
    case specifically for non controllers. It seems we would exit
    before the ovs workaround has had a chance to execute. This moves
    the block up a few lines to avoid this condition. As with the
    other two reviews noted here, this will need to go into newton
    and then mitaka too.

    Change-Id: If905de82d96302334ebe02de9c43f00faed9b72b
    Related-Bug: 1635205
    (cherry picked from commit 5a472f196e3392bf4187d4498f7c50db596f360a)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 5.1.0 release.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/newton
Review: https://review.openstack.org/413524

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/399708
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=afcb6e01f3af573a7bdd286a65b71eee48cec204
Submitter: Jenkins
Branch: master

commit afcb6e01f3af573a7bdd286a65b71eee48cec204
Author: marios <email address hidden>
Date: Fri Nov 18 19:18:54 2016 +0200

    Make the openvswitch 2.4->2.5 upgrade more robust

    In I9b1f0eaa0d36a28e20b507bec6a4e9b3af1781ae and
    I11fcf688982ceda5eef7afc8904afae44300c2d9 we added a manual step
    for upgrading openvswitch in order to specify the --nopostun
    as discussed in the bug below.

    This change adds a minor update to make this workaround more
    robust. It removes any existing rpms that may be around from
    an earlier run, and also checks that the rpms installed are
    at least newer than the version we are on.

    This also refactors the code into a common definition in the
    pacemaker_common_functions.sh which is included even for the
    heredocs generating upgrade scripts during init. Thanks
    Sofer Athlan-Guyot and Jirka Stransky for help with that.

    Change-Id: Idc863de7b5a8c116c990ee8c1472cfe377836d37
    Related-Bug: 1635205

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/413524
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=7240998433f9fac3af47d4a2b40f52b241e8bdef
Submitter: Jenkins
Branch: stable/newton

commit 7240998433f9fac3af47d4a2b40f52b241e8bdef
Author: marios <email address hidden>
Date: Fri Nov 18 19:18:54 2016 +0200

    Make the openvswitch 2.4->2.5 upgrade more robust

    In I9b1f0eaa0d36a28e20b507bec6a4e9b3af1781ae and
    I11fcf688982ceda5eef7afc8904afae44300c2d9 we added a manual step
    for upgrading openvswitch in order to specify the --nopostun
    as discussed in the bug below.

    This change adds a minor update to make this workaround more
    robust. It removes any existing rpms that may be around from
    an earlier run, and also checks that the rpms installed are
    at least newer than the version we are on.

    This also refactors the code into a common definition in the
    pacemaker_common_functions.sh which is included even for the
    heredocs generating upgrade scripts during init. Thanks
    Sofer Athlan-Guyot and Jirka Stransky for help with that.

    Change-Id: Idc863de7b5a8c116c990ee8c1472cfe377836d37
    Related-Bug: 1635205
    (cherry picked from commit afcb6e01f3af573a7bdd286a65b71eee48cec204)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 2.2.0 release.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Alex Schultz (<email address hidden>) on branch: master
Review: https://review.openstack.org/397283
Reason: Abandoning this patch per the TripleO Patch Abandonment guidelines (https://specs.openstack.org/openstack/tripleo-specs/specs/policy/patch-abandonment.html). If you wish to have this restored and cannot do so yourself, please reach out via #tripleo on freenode or the OpenStack Dev mailing list.