Cinder volume update failed

[huangtianhua]

1. create a stack with cinder volume:
*************************************
    heat_template_version: 2013-05-23
    parameters:
      size:
        type: string
        default: 2
    resources:
      v1:
        type: OS::Cinder::Volume
        description: for test
        properties:
          size: {get_param: size}
*************************************

2. update the stack to change size of volume

3. the stack update failed, the reason is: http://paste.openstack.org/show/586508/

4. we get the live attributes before update, and get the 'metadata={}' for this case. so we try to update the metadata with None value, then the error happened.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/389113

[Rabi Mishra (rabi)]

Are we comparing the resource properties form updated template with live state? I could not reproduce this in master, may be I'm missing something.

[huangtianhua (huangtianhua)]

after get live properties for the resource, we get the before_props with 'metadata: {}', but after_props.get('metadata') is None, so we will get prop_diff with 'metadata: None', so we will update with 'metadata: None'.

[Rabi Mishra (rabi)]

So this happens when if you've the 'observe_on_update' flag set in the config. I think we've agreed that the user would use --converge flag during update rather than we having a flag in the config. This bug would still probably be valid. However, we can handle all resources that have similar issues together when implementing that.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/389113
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=5cf81b2ae3b667399d637f358340685736c68b30
Submitter: Jenkins
Branch: master

commit 5cf81b2ae3b667399d637f358340685736c68b30
Author: huangtianhua <email address hidden>
Date: Thu Oct 20 17:53:33 2016 +0800

    Set default value for 'metadata' of cinder volume

    Set default value of 'metadata' to {}, to make sure
    update cinder volume success when observe_on_update
    is enabled.

    Change-Id: I006d8612f4d9fd0633695a17ad3c8f0ca37dbb97
    Closes-Bug: #1635164

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/heat 8.0.0.0b2 development milestone.