Bam2Egg does not convert Collision Flags

Bug #1635163 reported by ponyboy837
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Panda3D
Fix Released
Undecided
rdb

Bug Description

Bam2Egg doesn't not convert collision flags. I noticed this as every time i converted a model even if i set specific collision flags for it. It always does the descend for the object type. Such as if it was Polyset. it'll always output 'polyset descend'. I also checked the code in EggSaver.cxx and confirmed my theory. If you check line 422, line 468, line 510, line 537 and line 576 you can clearly see it always defaults to CF_Descend which means just a descend flag.

The version i found this on is Panda3D 1.10.0 and on a Windows 8.

Revision history for this message
rdb (rdb) wrote :

I can fix the flags "intangible" and "level", although the converted model will always have "descend" and never have "keep" set due to the fact that loading an .egg makes the collision geometry imported separately altogether, so the bam2egg process will have to keep them separate as well. This shouldn't make a difference for loading the resulting .egg though.

Changed in panda3d:
assignee: nobody → rdb (rdb)
status: New → In Progress
Revision history for this message
rdb (rdb) wrote :

Fixed. "intangible" and "level" flags are now kept.

"descend" is always written because it's not actually at all useful not to set it.
"keep" is never written because bam2egg always writes the collision geometry separately from the visible geometry, so it's not needed.

Changed in panda3d:
milestone: none → 1.9.3
status: In Progress → Fix Committed
Revision history for this message
ponyboy837 (ponyboy837) wrote :

What about "turnstile", "event", "solid" and "intangible"?

Revision history for this message
rdb (rdb) wrote :

I fixed "intangible" as stated above. All the other flags you mentioned have no meaning and effect whatsoever in Panda3D - the .egg loader completely ignores them.

Revision history for this message
ponyboy837 (ponyboy837) wrote :

Really? They do nothing? Well can i ask you something then? When i set my collision to have the level flag on slopes. The avatar doesn't slide down as intended but the avatar will jitter up and down instead. Do you know what causes this?

Revision history for this message
rdb (rdb) wrote :

I'm afraid I don't. Might be some issue in the relevant collision test. I've never used the "level" flag myself though.

If you can create a small self-contained test case to reproduce the issue, I would suggest filing a bug report and attaching the test case.

Revision history for this message
ponyboy837 (ponyboy837) wrote :

Alright will do.

Revision history for this message
ponyboy837 (ponyboy837) wrote :
rdb (rdb)
Changed in panda3d:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.