File descriptor leak in storlet-gateway

Bug #1634721 reported by Akihito Takai
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
storlets
Fix Released
Undecided
Akihito Takai

Bug Description

we found that storlet_gateway leaks the file descriptors of "input_data_read_fd" in PUT request of storlet python.

# sudo pgrep swift-proxy | xargs -n 1 sudo lsof -p | grep pipe
# for x in `seq 5` ; do curl -H 'X-Auth-Token: XXXXXXXXXXXX' -s -w '%{http_ code}\n' -X PUT http://127.0.0.1:80/v1/AUTH_XXXXXXXXXXX/myobjects/test_object -T ./obj -H 'X-Run-Storlet: simple.py' ; done
201
201
201
201
201
# sudo pgrep swift-proxy | xargs -n 1 sudo lsof -p | grep pipe
swift-pro 24736 swift 25r FIFO 0,8 0t0 371809 pipe
swift-pro 24736 swift 26r FIFO 0,8 0t0 368541 pipe
swift-pro 24736 swift 27r FIFO 0,8 0t0 371279 pipe
swift-pro 24736 swift 28r FIFO 0,8 0t0 371819 pipe
swift-pro 24736 swift 29r FIFO 0,8 0t0 371824 pipe

Akihito Takai (takaiak)
Changed in storlets:
assignee: nobody → Akihito Takai (takaiak)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to storlets (master)

Fix proposed to branch: master
Review: https://review.openstack.org/388288

Changed in storlets:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to storlets (master)

Reviewed: https://review.openstack.org/388288
Committed: https://git.openstack.org/cgit/openstack/storlets/commit/?id=3ea09dea15147634ea5a5abff752a329464d9789
Submitter: Jenkins
Branch: master

commit 3ea09dea15147634ea5a5abff752a329464d9789
Author: Akihito Takai <email address hidden>
Date: Wed Oct 19 11:23:39 2016 +0900

    Fix FD leak in storlet_gateway

    storlet_gateway leaks the FD of "input_data_read_fd" in PUT request.
    This patch prevent to leak the FD of "input_data_read_fd".

    Change-Id: Ic61049e18f450ec3b0b0e7bae9d55b889f80baf3
    Closes-Bug: #1634721

Changed in storlets:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.