Handle route-retracts from the agents during instance deletion correctly

Bug #1634612 reported by Ananth Suryanarayana
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R3.1
Won't Fix
Medium
Ananth Suryanarayana
R3.2
Fix Committed
Medium
Ananth Suryanarayana
Trunk
Fix Committed
Medium
Ananth Suryanarayana

Bug Description

Handle route-retracts from the agents during instance deletion correctly

Relax vrf_membership check when route retracts are received after instance is marked as deleted. Agents first send retract for all advertised routes and then they send unsubscribe request.

Current code flaps the session if route-retract is received when the instance is still marked for deletion.. This is incorrect and can happen in production code as part of normal instance deletion process

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/25001
Submitter: Ananth Suryanarayana (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.2

Review in progress for https://review.opencontrail.org/25243
Submitter: Ananth Suryanarayana (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/25001
Committed: http://github.org/Juniper/contrail-controller/commit/16380742863cb72b9e7718c12d81e49179e3af44
Submitter: Zuul
Branch: master

commit 16380742863cb72b9e7718c12d81e49179e3af44
Author: Ananth Suryanarayana <email address hidden>
Date: Mon Oct 17 10:07:15 2016 -0700

Handle route-retracts from the agents during instance deletion correctly

o Relax vrf_membership check when route retracts are received after instance is
marked as deleted. Agents first send retract for all advertised routes and
then they send unsubscribe request
o Fix issue in mock-agent to encode retracted routes correctly, based on the
family type

Change-Id: Ie141c8db8c22fb9ec824a83cca4dc4e38e65e5ea
Partial-Bug: #1634612

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/25243
Committed: http://github.org/Juniper/contrail-controller/commit/f66237bd8045865311c51b048193040c4338f5b7
Submitter: Zuul
Branch: R3.2

commit f66237bd8045865311c51b048193040c4338f5b7
Author: Ananth Suryanarayana <email address hidden>
Date: Mon Oct 17 10:07:15 2016 -0700

Handle route-retracts from the agents during instance deletion correctly

o Relax vrf_membership check when route retracts are received after instance is
marked as deleted. Agents first send retract for all advertised routes and
then they send unsubscribe request
o Fix issue in mock-agent to encode retracted routes correctly, based on the
family type

Change-Id: Ie141c8db8c22fb9ec824a83cca4dc4e38e65e5ea
Partial-Bug: #1634612

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.