StackLight

yaml templating used by plugins may lead to wrong data unmarshalling

Bug #1634461 reported by Swann Croiset
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
StackLight
Fix Released
Medium
LMA-Toolchain Fuel Plugins
StackLight 1.0.0
0.10
Won't Fix
Low
Unassigned
StackLight 0.10.2

Bug Description

For grafana plugin the following hiera entry:

# /etc/hiera/plugins/influxdb_grafana.yaml:
lma::influxdb::password: 1243

leads to fail the configuration of grafana datasource:

Failed to create save 'lma' (HTTP response: 400/'[{"classification":"DeserializationError","message":"json: cannot unmarshal number into Go value of type string"}]')

The following YAML syntax enforces string casting:

lma::influxdb::password: >
    1243

This issue could be present at several places and need to be checked for all plugins.

See original description
Tags: grafana
Swann Croiset (swann-w)
Changed in lma-toolchain:
assignee: nobody → LMA-Toolchain Fuel Plugins (mos-lma-toolchain)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-plugin-influxdb-grafana (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/387997

Simon Pasquier (simon-pasquier)
Changed in lma-toolchain:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-plugin-influxdb-grafana (master)

Reviewed: https://review.openstack.org/387997
Committed: https://git.openstack.org/cgit/openstack/fuel-plugin-influxdb-grafana/commit/?id=c6193a22165d2d69aac447da2ee7150306254054
Submitter: Jenkins
Branch: master

commit c6193a22165d2d69aac447da2ee7150306254054
Author: Swann Croiset <email address hidden>
Date: Tue Oct 18 14:27:20 2016 +0200

    Enforce string type for passwords in hiera data

    Related-Bug: #1634461
    Change-Id: I203c2b0719d7ca2464bd034c6fea2404d693e1f1

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-plugin-influxdb-grafana (stable/1.0)

Related fix proposed to branch: stable/1.0
Review: https://review.openstack.org/390579

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-plugin-influxdb-grafana (stable/1.0)

Reviewed: https://review.openstack.org/390579
Committed: https://git.openstack.org/cgit/openstack/fuel-plugin-influxdb-grafana/commit/?id=6b2c8b1ac3067ee32afc592beebfb20aeb4db6ca
Submitter: Jenkins
Branch: stable/1.0

commit 6b2c8b1ac3067ee32afc592beebfb20aeb4db6ca
Author: Swann Croiset <email address hidden>
Date: Tue Oct 18 14:27:20 2016 +0200

    Enforce string type for passwords in hiera data

    Related-Bug: #1634461
    Change-Id: I203c2b0719d7ca2464bd034c6fea2404d693e1f1
    (cherry picked from commit c6193a22165d2d69aac447da2ee7150306254054)

Swann Croiset (swann-w)
Changed in lma-toolchain:
status: Triaged → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-plugin-elasticsearch-kibana (master)

Change abandoned by Swann Croiset (<email address hidden>) on branch: master
Review: https://review.openstack.org/391750
Reason: superseded by simon patch.
thanks for your time

Simon Pasquier (simon-pasquier)
Changed in lma-toolchain:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.