Don't try to delete trust if trustor not found

Bug #1634362 reported by huangtianhua
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
huangtianhua

Bug Description

1. deferred_auth_method with default value trusts
 2. create a stack with a token of projectA & user1 , a trust will be created
 3. then delete user1 in keystone, we can find the trust was deleted at the same time.
 4. delete the stack with a token of projectA & user2, after all resources have been deleted successfully, heat try to delete the trust, but an exception happened, because
the trustor(user1) is deleted, the stack went to DELETE_FAILED.
There is no need to delete trust for this situation, because the trust has been deleted already.

Changed in heat:
assignee: nobody → huangtianhua (huangtianhua)
summary: - trust left after delete stack
+ Don't try to delete trust if trustor not found
description: updated
Changed in heat:
importance: Undecided → Medium
milestone: none → ocata-1
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/388561

Changed in heat:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/388561
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=551b185066fe634906022829fe65026fa189fb76
Submitter: Jenkins
Branch: master

commit 551b185066fe634906022829fe65026fa189fb76
Author: huangtianhua <email address hidden>
Date: Wed Oct 19 16:54:30 2016 +0800

    Don't try to delete trust if trustor not found

    Keystone deletes the trust when delete the trustor, so
    don't try to delete the trust again in heat delete stack
    with another user in same project.

    Change-Id: I2376f2702672d28b24de5ac4ad0bb81fd7171abe
    Closes-Bug: #1634362

Changed in heat:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/398700

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/heat 8.0.0.0b1

This issue was fixed in the openstack/heat 8.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/436845

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/436845
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=2b90a14102302cfbd8d246a3e093d7b11886f0c9
Submitter: Jenkins
Branch: master

commit 2b90a14102302cfbd8d246a3e093d7b11886f0c9
Author: huangtianhua <email address hidden>
Date: Wed Feb 22 17:34:06 2017 +0800

    Catch Unauthorized in delete_trust()

    This change improves the bug fixing
    I2376f2702672d28b24de5ac4ad0bb81fd7171abe
    to handle the unauthorized exception in delete_trust()
    of */heat_keystoneclient.KsClientWrapper.

    Change-Id: Ic6fd336f63ae995dd4d76b0f31daa85e86f55ab0
    Closes-Bug: #1634362

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/447395

tags: added: ocata-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on heat (stable/newton)

Change abandoned by huangtianhua (<email address hidden>) on branch: stable/newton
Review: https://review.openstack.org/398700
Reason: See https://review.openstack.org/#/c/447395/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/447397

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (stable/ocata)

Reviewed: https://review.openstack.org/447397
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=ca1685f3ebb8be7c6c6537f02b540cd34e5f5c7e
Submitter: Jenkins
Branch: stable/ocata

commit ca1685f3ebb8be7c6c6537f02b540cd34e5f5c7e
Author: huangtianhua <email address hidden>
Date: Wed Feb 22 17:34:06 2017 +0800

    Catch Unauthorized in delete_trust()

    This change improves the bug fixing
    I2376f2702672d28b24de5ac4ad0bb81fd7171abe
    to handle the unauthorized exception in delete_trust()
    of */heat_keystoneclient.KsClientWrapper.

    Change-Id: Ic6fd336f63ae995dd4d76b0f31daa85e86f55ab0
    Closes-Bug: #1634362
    (cherry picked from commit 2b90a14102302cfbd8d246a3e093d7b11886f0c9)

tags: added: in-stable-ocata
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/451739

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on heat (stable/newton)

Change abandoned by huangtianhua (<email address hidden>) on branch: stable/newton
Review: https://review.openstack.org/447395

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/heat 9.0.0.0b1

This issue was fixed in the openstack/heat 9.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (stable/newton)

Reviewed: https://review.openstack.org/451739
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=fadca70990ceee8f3b45ee8dd0e5d9e8f57f96b7
Submitter: Jenkins
Branch: stable/newton

commit fadca70990ceee8f3b45ee8dd0e5d9e8f57f96b7
Author: huangtianhua <email address hidden>
Date: Wed Feb 22 17:34:06 2017 +0800

    Catch Unauthorized in delete_trust()

    Keystone deletes the trust when delete the trustor, so
    don't try to delete the trust again in heat delete stack
    with another user in same project.

    Closes-Bug: #1634362
    (cherry picked from commit 2b90a14102302cfbd8d246a3e093d7b11886f0c9)

    Change-Id: Ic6fd336f63ae995dd4d76b0f31daa85e86f55ab0

tags: added: in-stable-newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/heat 8.0.1

This issue was fixed in the openstack/heat 8.0.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/heat 7.0.4

This issue was fixed in the openstack/heat 7.0.4 release.

Zane Bitter (zaneb)
tags: removed: ocata-backport-potential
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.