Agent crash in PathPreferenceState::Process()

[amit surana]

3.1 b 32

If same AAP in local compute node has one path in active-backup mode and one in active-active mode, then there is a cyclic reference causing crash.

Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/usr/bin/contrail-vrouter-agent'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0 _int_malloc (av=0x7fb9d0000020, bytes=40) at malloc.c:3302
#0 _int_malloc (av=0x7fb9d0000020, bytes=40) at malloc.c:3302
#1 0x00007fba21f576c0 in __GI___libc_malloc (bytes=40) at malloc.c:2891
#2 0x00007fba22814dad in operator new(unsigned long) () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#3 0x0000000000b0373d in std::_Rb_tree<PathPreferenceState*, PathPreferenceState*, std::_Identity<PathPreferenceState*>, std::less<PathPreferenceState*>, std::allocator<PathPreferenceState*> >::_M_insert_unique(PathPreferenceState* const&) ()
#4 0x0000000000b01845 in PathPreferenceState::Process() ()
#5 0x0000000000b01a89 in PathPreferenceModule::Resolve() ()
#6 0x0000000000b0162b in PathPreferenceState::Process() ()
#7 0x0000000000b01a89 in PathPreferenceModule::Resolve() ()
#8 0x0000000000b0162b in PathPreferenceState::Process() ()
#9 0x0000000000b01a89 in PathPreferenceModule::Resolve() ()
#10 0x0000000000b0162b in PathPreferenceState::Process() ()
#11 0x0000000000b01a89 in PathPreferenceModule::Resolve() ()
#12 0x0000000000b0162b in PathPreferenceState::Process() ()
#13 0x0000000000b01a89 in PathPreferenceModule::Resolve() ()
#14 0x0000000000b0162b in PathPreferenceState::Process() ()
#15 0x0000000000b01a89 in PathPreferenceModule::Resolve() ()
#16 0x0000000000b0162b in PathPreferenceState::Process() ()
#17 0x0000000000b01a89 in PathPreferenceModule::Resolve() ()
#18 0x0000000000b0162b in PathPreferenceState::Process() ()
#19 0x0000000000b01a89 in PathPreferenceModule::Resolve() ()
#20 0x0000000000b0162b in PathPreferenceState::Process() ()

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/25107
Submitter: Naveen N (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/25124
Submitter: Naveen N (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/25126
Submitter: Naveen N (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/25107
Submitter: Naveen N (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/25126
Submitter: Naveen N (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/25174
Submitter: Naveen N (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/25124
Submitter: Naveen N (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/25174
Committed: http://github.org/Juniper/contrail-controller/commit/54feff049fc19ba612933e54985c82cf664309ca
Submitter: Zuul
Branch: R3.0.3.x

commit 54feff049fc19ba612933e54985c82cf664309ca
Author: Naveen N <email address hidden>
Date: Thu Oct 20 18:43:20 2016 +0530

* Publish AAP route with high preference

1> Handle AAP transition from active-backup to active-active
and vice versa
2> For a same route if there are path with tracking IP and
one with no tracking ip, and tracking IP route is not present
this particular path used to cause continous evaluation
of path for state machine change, fix the same by removing
recursive call.
Closes-bug:#1634253,#1634252

Change-Id: I3dd1e36b727c9de3d78bd87433e32c01e03b2bdf

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/25107
Committed: http://github.org/Juniper/contrail-controller/commit/2142add0b825144c8a832507d81308da9cffeee9
Submitter: Zuul
Branch: R3.1

commit 2142add0b825144c8a832507d81308da9cffeee9
Author: Naveen N <email address hidden>
Date: Thu Oct 20 18:43:20 2016 +0530

* Publish AAP route with high preference

1> Handle AAP transition from active-backup to active-active
and vice versa
2> For a same route if there are path with tracking IP and
one with no tracking ip, and tracking IP route is not present
this particular path used to cause continous evaluation
of path for state machine change, fix the same by removing
recursive call.
Closes-bug:#1634253,#1634252

Change-Id: I3dd1e36b727c9de3d78bd87433e32c01e03b2bdf

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/25124
Committed: http://github.org/Juniper/contrail-controller/commit/82d7050c01cf1d4c082afb8044319cf42f409a5b
Submitter: Zuul
Branch: master

commit 82d7050c01cf1d4c082afb8044319cf42f409a5b
Author: Naveen N <email address hidden>
Date: Thu Oct 20 18:43:20 2016 +0530

* Publish AAP route with high preference

1> Handle AAP transition from active-backup to active-active
and vice versa
2> For a same route if there are path with tracking IP and
one with no tracking ip, and tracking IP route is not present
this particular path used to cause continous evaluation
of path for state machine change, fix the same by removing
recursive call.
Closes-bug:#1634253,#1634252

Change-Id: I3dd1e36b727c9de3d78bd87433e32c01e03b2bdf

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/25126
Submitter: Naveen N (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/25289
Submitter: Naveen N (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/25289
Committed: http://github.org/Juniper/contrail-controller/commit/85e3acbab7e5976a553a10f1926666163497cc5a
Submitter: Zuul
Branch: R3.2

commit 85e3acbab7e5976a553a10f1926666163497cc5a
Author: Naveen N <email address hidden>
Date: Thu Oct 20 18:43:20 2016 +0530

* Publish AAP route with high preference

1> Handle AAP transition from active-backup to active-active
and vice versa
2> For a same route if there are path with tracking IP and
one with no tracking ip, and tracking IP route is not present
this particular path used to cause continous evaluation
of path for state machine change, fix the same by removing
recursive call.
Closes-bug:#1634253,#1634252

Change-Id: I3dd1e36b727c9de3d78bd87433e32c01e03b2bdf

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/25126
Submitter: Naveen N (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/25693
Submitter: Naveen N (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/25698
Submitter: Naveen N (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/25126
Committed: http://github.org/Juniper/contrail-controller/commit/7a261c9ccec6aa62697c59ec181a95df9119d58d
Submitter: Zuul
Branch: R3.0

commit 7a261c9ccec6aa62697c59ec181a95df9119d58d
Author: Naveen N <email address hidden>
Date: Thu Oct 20 18:43:20 2016 +0530

* Publish AAP route with high preference

1> Handle AAP transition from active-backup to active-active
and vice versa
2> For a same route if there are path with tracking IP and
one with no tracking ip, and tracking IP route is not present
this particular path used to cause continous evaluation
of path for state machine change, fix the same by removing
recursive call.
Closes-bug:#1634253,#1634252

Change-Id: I3dd1e36b727c9de3d78bd87433e32c01e03b2bdf

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/25698
Submitter: Naveen N (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/25698
Committed: http://github.org/Juniper/contrail-controller/commit/ab1d84f83841477070b55b20f1e7f6117afd0393
Submitter: Zuul
Branch: R3.0.2.x

commit ab1d84f83841477070b55b20f1e7f6117afd0393
Author: Naveen N <email address hidden>
Date: Thu Oct 20 18:43:20 2016 +0530

* Publish AAP route with high preference

1> Handle AAP transition from active-backup to active-active
and vice versa
2> For a same route if there are path with tracking IP and
one with no tracking ip, and tracking IP route is not present
this particular path used to cause continous evaluation
of path for state machine change, fix the same by removing
recursive call.
Closes-bug:#1634253,#1634252

Change-Id: I3dd1e36b727c9de3d78bd87433e32c01e03b2bdf