NetApp cDOT driver fails to clone from NFS image cache

[Clinton Knight]

In some cases, the NetApp cDOT NFS driver fails to clone from an NFS image cache. Root cause is code that compares extra specs of the new volume to capability lists that the driver reports to the scheduler (such as a list of disk types). It fails because a list is mutable, so not hashable, so the code cannot do set-based comparison operations against extra specs. The simple fix is to convert the capability lists to tuples before doing set operations.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/390463

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/390463
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=beed5c7789d4d05137a1f8dce87c56a7c3500cdf
Submitter: Jenkins
Branch: master

commit beed5c7789d4d05137a1f8dce87c56a7c3500cdf
Author: Clinton Knight <email address hidden>
Date: Mon Oct 17 12:55:47 2016 -0400

    NetApp cDOT driver fails to clone from NFS cache

    In some cases, the NetApp cDOT NFS driver fails to clone from an
    NFS image cache. Root cause is code that compares extra specs of
    the new volume to capability lists that the driver reports to the
    scheduler (such as a list of disk types). It fails because a list
    is mutable, so not hashable, so the code cannot do set-based
    comparison operations against extra specs. The simple fix is to
    stop doing set operations on extra specs. Also, update the time
    on the image cache file so that our tests can distinguish between
    a fast clone from cache and the slower copy-from-Glance fallback.

    Change-Id: I1dfacd24d49b11967eeb0c6b8560114d01952d74
    Closes-Bug: #1634203

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/407557

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 10.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/407557
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=f6a4f9346922f1eb91698114b57404f77dc0aae7
Submitter: Jenkins
Branch: stable/newton

commit f6a4f9346922f1eb91698114b57404f77dc0aae7
Author: Clinton Knight <email address hidden>
Date: Mon Oct 17 12:55:47 2016 -0400

    NetApp cDOT driver fails to clone from NFS cache

    In some cases, the NetApp cDOT NFS driver fails to clone from an
    NFS image cache. Root cause is code that compares extra specs of
    the new volume to capability lists that the driver reports to the
    scheduler (such as a list of disk types). It fails because a list
    is mutable, so not hashable, so the code cannot do set-based
    comparison operations against extra specs. The simple fix is to
    stop doing set operations on extra specs. Also, update the time
    on the image cache file so that our tests can distinguish between
    a fast clone from cache and the slower copy-from-Glance fallback.

    Change-Id: I1dfacd24d49b11967eeb0c6b8560114d01952d74
    Closes-Bug: #1634203
    (cherry picked from commit beed5c7789d4d05137a1f8dce87c56a7c3500cdf)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 9.1.2 release.