Remove unused SUBMITTED audit state

[Vincent Françoise]

The SUBMITTED is not reference nor used within the Watcher codebase. Therefore, we should remove all its references from the code.

Here are the files containing the references to remove:

watcher/objects/audit.py
watcher/tests/api/v1/test_actions.py
watcher/tests/api/v1/test_audit_templates.py
watcher/tests/api/v1/test_audits.py
watcher_tempest_plugin/tests/api/admin/test_audit.py

[Jaewoo Park (aselius)]

for the tests(actions, audit_templates, audits) that makes use of the submitted state, is it fine to remove the test altogether? it looks like most of the tests are disallowing update when the state is submitted.

[Vincent Françoise (vincent-francoise)]

Seems to me the tests referencing the SUBMITTED state do not need that specific value to work, so I reckon you should probably just replace the SUBMITTED with another state, say, SUCCEEDED.

In the case of watcher_tempest_plugin/tests/api/admin/test_audit.py, simply removing the value from the list should suffice.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/394635

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/394635
Committed: https://git.openstack.org/cgit/openstack/watcher/commit/?id=4973dd6bf642507541426cf6db934c41b61ee54b
Submitter: Jenkins
Branch: master

commit 4973dd6bf642507541426cf6db934c41b61ee54b
Author: Jaewoo Park <email address hidden>
Date: Mon Nov 7 13:16:31 2016 -0800

    Remove unused SUBMITTED audit state

    Submitted state is not referenced nor used in the Watcher codebase,
    and hence removed the references to the state from the codebase.

    Change-Id: Ibb0cf5125e2d93683739abf35030b7cf5cb1b056
    Closes-Bug: 1634150

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/watcher 0.32.0 release.