Error: Puppet::Parser::AST::Resource failed with error ArgumentError: Cannot alias Host

[Emilien Macchi]

It seems like since we merged https://review.openstack.org/#/c/384756/ - our HA jobs are randomly failing with this trace:

Error: Puppet::Parser::AST::Resource failed with error ArgumentError: Cannot alias Host[external] to [""]; resource ["Host", ""] already declared at /etc/puppet/modules/tripleo/manifests/vip_hosts.pp:37

See more details here:
http://logs.openstack.org/18/386118/2/check-tripleo/gate-tripleo-ci-centos-7-ovb-ha/bae11ba/logs/postci.txt.gz#_2016-10-14_14_25_04_000

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/386716

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/386716
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=ccc3a569833ce13c472d48815eaeb153ec650b54
Submitter: Jenkins
Branch: master

commit ccc3a569833ce13c472d48815eaeb153ec650b54
Author: Dan Prince <email address hidden>
Date: Fri Oct 14 13:39:01 2016 -0400

    Ensure all HostsDeployments finish before puppet

    This makes sure that the Host settings for all deployments are finished
    before starting the AllNodesDeployments which execute puppet.

    Change-Id: Ibe604472255ce905ca2c1dca2a9b07a6f8f40e47
    Related-bug: #1633565

[Jiří Stránský (jistr)]

Sounds like this could affect Newton too, right?

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/newton
Review: https://review.openstack.org/387982

[Martin Mágr (mmagr)]

I can confirm this is affecting Newton.

[Attila Fazekas (afazekas)]

I have the same puppet error message from newton.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/387982
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=a909a656c9070aa02bc3a15dc3fd49870d94981a
Submitter: Jenkins
Branch: stable/newton

commit a909a656c9070aa02bc3a15dc3fd49870d94981a
Author: Dan Prince <email address hidden>
Date: Fri Oct 14 13:39:01 2016 -0400

    Ensure all HostsDeployments finish before puppet

    This makes sure that the Host settings for all deployments are finished
    before starting the AllNodesDeployments which execute puppet.

    Change-Id: Ibe604472255ce905ca2c1dca2a9b07a6f8f40e47
    Related-bug: #1633565
    (cherry picked from commit ccc3a569833ce13c472d48815eaeb153ec650b54)