Uploading new/existing SmartEvidence framework doesn't work

[Gregor Anželj]

When I try to upload new SmartEvidence framework (in administration section) it does't work. The matrix file is a valid JSON file. I have also deleted existing SmartEvidence framework and tried to re-install it. The result is the same.

This is probably due to OS, since I am working / testing that on Windows.

The debug message was:

[WAR] 58 (module\framework\lib.php:72) file_get_contents(D:\xampp\htdocs\mahara1610\module/framework/matrices/D:\xampp\tmp\php91F8.tmp): failed to open stream: Invalid argument

[Gregor Anželj (gregor-anzelj)]

Oh and I forgot all the standard details:

Windows OS, MySQL, Mahara 16.10 RC2

[Gregor Anželj (gregor-anzelj)]

Additiona testing shows that lines 111-113 in htdocs/module/framework/lib.php are problematic. When I comment out those lines, the upload works correctly.

[Kristina Hoeppner (kris-hoeppner)]

Thanks for reporting and pointing out the lines that might be causing the issue. We'll see what we can do.

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/7140

[Robert Lyon (robertl-9)]

Hi Gregor,

Thanks for this report and for diagnosing the issue

I've added a patch to fix this - can you please test to see if it is ok
https://reviews.mahara.org/#/c/7140/

Cheers

Robert

[Gregor Anželj (gregor-anzelj)]

Robert hi.

I've tested it and it works like a charm... ;)

Thanks

Gregor

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/7140
Committed: https://git.mahara.org/mahara/mahara/commit/e62618110fd455d176621eee694ecef1d3fd7fb6
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit e62618110fd455d176621eee694ecef1d3fd7fb6
Author: Robert Lyon <email address hidden>
Date: Tue Oct 18 09:17:13 2016 +1300

Bug 1633213: Removing check for local file

An earlier rendition of the way we added new matrix files was to place
them into the matrices dir and then upload them by name only.

But now we use the file upload field and so don't need this check
anymore

behatnotneeded

Change-Id: Ia37ca05370cdc53dd7836b572320c14e4e3bfcfc
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "16.10_STABLE" branch: https://reviews.mahara.org/7158

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/7158
Committed: https://git.mahara.org/mahara/mahara/commit/2a529380f8a1009a71270146784d5e395b1a7bd5
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.10_STABLE

commit 2a529380f8a1009a71270146784d5e395b1a7bd5
Author: Robert Lyon <email address hidden>
Date: Tue Oct 18 09:17:13 2016 +1300

Bug 1633213: Removing check for local file

An earlier rendition of the way we added new matrix files was to place
them into the matrices dir and then upload them by name only.

But now we use the file upload field and so don't need this check
anymore

behatnotneeded

Change-Id: Ia37ca05370cdc53dd7836b572320c14e4e3bfcfc
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit e62618110fd455d176621eee694ecef1d3fd7fb6)