syntribos dry_run throwing error

Bug #1632891 reported by Rahul U Nair
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
syntribos
Fix Released
High
Rahul U Nair

Bug Description

Syntribos dry run throwing error, it looks like the latest change to remove init_request sending from dry run is causing this. Please find the traceback:
Traceback (most recent call last):
  File "/Users/runnikri/Coding/py27/bin/syntribos", line 10, in <module>
    sys.exit(entry_point())
  File "/Users/runnikri/Coding/py27/lib/python2.7/site-packages/syntribos/runner.py", line 301, in entry_point
    Runner.run()
  File "/Users/runnikri/Coding/py27/lib/python2.7/site-packages/syntribos/runner.py", line 176, in run
    cls.dry_run(list_of_tests, file_path, req_str)
  File "/Users/runnikri/Coding/py27/lib/python2.7/site-packages/syntribos/runner.py", line 195, in dry_run
    test_cases = list(test_class.get_test_cases(file_path, req_str))
  File "/Users/runnikri/Coding/py27/lib/python2.7/site-packages/syntribos/tests/fuzz/base_fuzz.py", line 127, in get_test_cases
    for fuzz_name, request, fuzz_string, param_path in fr:
  File "/Users/runnikri/Coding/py27/lib/python2.7/site-packages/syntribos/tests/fuzz/datagen.py", line 34, in fuzz_request
    strings, getattr(req, fuzz_type), req.action_field,
AttributeError: 'NoneType' object has no attribute 'data'

Revision history for this message
Rahul U Nair (rahulunair) wrote :

This is because get_test_cases method in datagen.py for fuzz tests require information on the init_req and this was given by the call to init_req. A possible way to fix this is to check if the init_req call is from dry_run and not actually send the request, but create the request object so that a init_req would be present.

Changed in syntribos:
assignee: nobody → Rahul U Nair (rahulunair)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to syntribos (master)

Fix proposed to branch: master
Review: https://review.openstack.org/385698

Changed in syntribos:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on syntribos (master)

Change abandoned by Rahul U Nair (<email address hidden>) on branch: master
Review: https://review.openstack.org/385698
Reason: Another patch that takes care of some of the concerns with dry run is ready for review: https://review.openstack.org/#/c/388261/ . Thus abandoning this one.

Revision history for this message
Charles Neill (charles-neill) wrote :

Fixed by 388261

Changed in syntribos:
status: In Progress → Fix Committed
importance: Undecided → High
Changed in syntribos:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.