[swarm 10.0] test deploy_with_redeploy_and_modify_settings doesn't tak into account nodes roles validation before deployment

[Alexandra]

1 swarm test is failed (10.0 iso #839):
https://product-ci.infra.mirantis.net/job/10.0.system_test.ubuntu.unlock_settings_tab/97/testReport/(root)/deploy_with_redeploy_and_modify_settings/deploy_with_redeploy_and_modify_settings/

A few configurations were failed: ['1Controller_2Computes_vlan', '1Controller_2Computes_gre', '1Controller_2Computes_tun', '1Controller_ceph_2Computes_ceph_vlan', '1Controller_1Compute_1cndr_mongo_3ceph', '3Controller_3Computes_ceph', '3Controller_mongo_3Computes_ceph', '1Controller_1Compute_1Cinder_3Ceph_Rados_vlan', '1Controller_2Computes_1Cinder_3Ceph_1Mongo_Ceph_Image_Ceilometer_vlan'] Please, check logs

Some of them are failed during initial deploy:

1Controller_ceph_2Computes_ceph_vlan: 'Role 'controller' in conflict with role 'ceph-osd'.' (https://bugs.launchpad.net/fuel/+bug/1631878)

1Controller_1Compute_1cndr_mongo_3ceph: 'Role 'mongo' restrictions mismatch: Ceilometer should be enabled in the environment settings.'
3Controller_mongo_3Computes_ceph: 'Role 'mongo' restrictions mismatch: Ceilometer should be enabled in the environment settings.'

3Controller_3Computes_ceph: 'Role 'ceph-osd' restrictions mismatch: Ceph should be enabled in the environment settings.'
1Controller_1Compute_1Cinder_3Ceph_Rados_vlan: 'Role 'ceph-osd' restrictions mismatch: Ceph should be enabled in the environment settings.'

[Alexandra (aallakhverdieva)]

Link to configs for test: https://github.com/openstack/fuel-qa/blob/master/fuelweb_test/tests/cluster_configs.yaml

[Oleksiy Molchanov (omolchanov)]

Fixed - https://review.openstack.org/#/c/384425/

[Alexandra (aallakhverdieva)]

Fails still reproduced:
https://product-ci.infra.mirantis.net/job/10.0.system_test.ubuntu.unlock_settings_tab/100/testReport/(root)/deploy_with_redeploy_and_modify_settings/

AssertionError: Task 'deploy' has incorrect status. error != ready, 'Role 'ceph-osd' restrictions mismatch: Ceph should be enabled in the environment settings.'
AssertionError: Task 'deploy' has incorrect status. error != ready, 'Role 'mongo' restrictions mismatch: Ceilometer should be enabled in the environment settings.'

[Oleksiy Molchanov (omolchanov)]

@Alexandra, it means you have not enabled ceph and ceilometer on your env. QA team, please check.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/421274

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/421278

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/421274
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=f5e7f2473bc7e5b7f9ed15921a0da0aadee762de
Submitter: Jenkins
Branch: stable/mitaka

commit f5e7f2473bc7e5b7f9ed15921a0da0aadee762de
Author: Dmitry Belyaninov <email address hidden>
Date: Tue Jan 17 13:40:08 2017 +0000

    Cluster configs update

    There are some restrictions for node roles and
    cluster settings. So we should change config
    to solve initial deployment fails.

    Change-Id: I46577cddb3062f3785544068f671dcc8d349c106
    Partial-Bug: 1632751

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/428681

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/428681
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=83202bc7c0b21ea80ab5cacf59673948bf70eb9d
Submitter: Jenkins
Branch: master

commit 83202bc7c0b21ea80ab5cacf59673948bf70eb9d
Author: Dmitry Belyaninov <email address hidden>
Date: Tue Jan 17 13:40:08 2017 +0000

    Cluster configs update

    There are some restrictions for node roles and
    cluster settings. So we should change config
    to solve initial deployment fails.

    Change-Id: I46577cddb3062f3785544068f671dcc8d349c106
    Partial-Bug: 1632751
    (cherry picked from commit f5e7f2473bc7e5b7f9ed15921a0da0aadee762de)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/421278
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=49550b80e4419c36bdd4883ed750e1766866f7f4
Submitter: Jenkins
Branch: stable/newton

commit 49550b80e4419c36bdd4883ed750e1766866f7f4
Author: Dmitry Belyaninov <email address hidden>
Date: Tue Jan 17 13:40:08 2017 +0000

    Cluster configs update

    There are some restrictions for node roles and
    cluster settings. So we should change config
    to solve initial deployment fails.

    Change-Id: I46577cddb3062f3785544068f671dcc8d349c106
    Partial-Bug: 1632751