show_route_test bgp ut crashes some times

Bug #1632519 reported by Ananth Suryanarayana
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R3.0
Fix Committed
Medium
Ananth Suryanarayana
R3.1
Fix Committed
Medium
Ananth Suryanarayana
R3.2
Fix Committed
Medium
Ananth Suryanarayana
Trunk
Fix Committed
Medium
Ananth Suryanarayana

Bug Description

Thread 1 (LWP 27641):
#0 __memcpy_sse2_unaligned () at ../sysdeps/x86_64/multiarch/memcpy-sse2-unaligned.S:36
#1 0x00002b368b81ee30 in std::string::_Rep::_M_clone(std::allocator<char> const&, unsigned long) () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#2 0x00002b368b81f48c in std::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string(std::string const&) () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#3 0x00000000010a87e1 in ShowRoute::ShowRoute (this=0x2b36cc0045b0) at build/debug/bgp/bgp_peer_types.h:2589
#4 0x000000000136e2a7 in __gnu_cxx::new_allocator<ShowRoute>::construct (this=0x3ea41f8, __p=0x2b36cc0045b0, __val=...) at /usr/include/c++/4.8/ext/new_allocator.h:130
#5 0x000000000136c5fe in __gnu_cxx::__alloc_traits<std::allocator<ShowRoute> >::construct<ShowRoute> (__a=..., __p=0x2b36cc0045b0, __arg=...) at /usr/include/c++/4.8/ext/alloc_traits.h:216
#6 0x000000000136c772 in std::vector<ShowRoute, std::allocator<ShowRoute> >::_M_insert_aux (this=0x3ea41f8, __position=<error reading variable: Cannot access memory at address 0x0>, __x=...) at /usr/include/c++/4.8/bits/vector.tcc:353
#7 0x000000000136a18e in std::vector<ShowRoute, std::allocator<ShowRoute> >::push_back (this=0x3ea41f8, __x=...) at /usr/include/c++/4.8/bits/stl_vector.h:913
#8 0x0000000001368c30 in ShowRouteVrfHandler::CallbackS1 (sr=0x3ea2b40, ps=..., stage=0, instNum=2, data=0x3ea41f0) at controller/src/bgp/bgp_sandesh.cc:344
#9 0x000000000136fcf8 in boost::detail::function::function_invoker5<bool (*)(Sandesh const*, RequestPipeline::PipeSpec, int, int, RequestPipeline::InstData*), bool, Sandesh const*, RequestPipeline::PipeSpec const&, int, int, RequestPipeline::InstData*>::invoke (function_ptr=..., a0=0x3ea2b40, a1=..., a2=0, a3=2, a4=0x3ea41f0) at /usr/include/boost/function/function_template.hpp:95
#10 0x0000000001673681 in boost::function5<bool, Sandesh const*, RequestPipeline::PipeSpec const&, int, int, RequestPipeline::InstData*>::operator() (this=0x3e95310, a0=0x3ea2b40, a1=..., a2=0, a3=2, a4=0x3ea41f0) at /usr/include/boost/function/function_template.hpp:767
#11 0x00000000016727e7 in RequestPipeline::PipeImpl::RunInstance (this=0x3e94120, instNum=2) at tools/sandesh/library/cpp/request_pipeline.cc:189
#12 0x0000000001672e9f in RequestPipeline::StageWorker::Run (this=0x3ea4930) at tools/sandesh/library/cpp/request_pipeline.cc:84
#13 0x0000000000f775d4 in TaskImpl::execute (this=0x2b3690c72940) at controller/src/base/task.cc:262
#14 0x00002b368b348b3a in ?? () from /usr/lib/libtbb.so.2
#15 0x00002b368b344816 in ?? () from /usr/lib/libtbb.so.2
#16 0x00002b368b343f4b in ?? () from /usr/lib/libtbb.so.2
#17 0x00002b368b3400ff in ?? () from /usr/lib/libtbb.so.2
#18 0x00002b368b3402f9 in ?? () from /usr/lib/libtbb.so.2
#19 0x00002b368b112184 in start_thread (arg=0x2b3693eac700) at pthread_create.c:312
#20 0x00002b368c07e37d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:111

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/24803
Submitter: Ananth Suryanarayana (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.0

Review in progress for https://review.opencontrail.org/24818
Submitter: Ananth Suryanarayana (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.1

Review in progress for https://review.opencontrail.org/24819
Submitter: Ananth Suryanarayana (<email address hidden>)

Nischal Sheth (nsheth)
tags: added: contrail-control
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/24822
Submitter: Nischal Sheth (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.1

Review in progress for https://review.opencontrail.org/24825
Submitter: Nischal Sheth (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.0

Review in progress for https://review.opencontrail.org/24827
Submitter: Nischal Sheth (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/24827
Committed: http://github.org/Juniper/contrail-controller/commit/89ae4afa06b3ba2e33c0e19d8dc3d408edd347f6
Submitter: Zuul
Branch: R3.0

commit 89ae4afa06b3ba2e33c0e19d8dc3d408edd347f6
Author: Nischal Sheth <email address hidden>
Date: Wed Oct 12 10:28:15 2016 -0700

Fix concurrency issues in caching string representation

Caching the representation in a lazy manner when ToString/ToUVE
etc. are called is prone to concurrency issues. Initialize the
string representation in the constructors for the following:

- String representation for BgpPeer ToString and ToUVEKey
- String representation for InetRoute and Inet6Route ToString
- String representation for XmppConnection ToUVEKey

Change-Id: I01df9271d76a4c03977f1cc0618f97179f283999
Closes-Bug: 1632519

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/24825
Committed: http://github.org/Juniper/contrail-controller/commit/07374496e73e8215390e79049cd3598c66639e1d
Submitter: Zuul
Branch: R3.1

commit 07374496e73e8215390e79049cd3598c66639e1d
Author: Nischal Sheth <email address hidden>
Date: Wed Oct 12 10:28:15 2016 -0700

Fix concurrency issues in caching string representation

Caching the representation in a lazy manner when ToString/ToUVE
etc. are called is prone to concurrency issues. Initialize the
string representation in the constructors for the following:

- String representation for BgpPeer ToString and ToUVEKey
- String representation for InetRoute and Inet6Route ToString
- String representation for XmppConnection ToUVEKey

Change-Id: I01df9271d76a4c03977f1cc0618f97179f283999
Closes-Bug: 1632519

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/24818
Committed: http://github.org/Juniper/contrail-controller/commit/42d37d3b08749c651b9c81d219c47ae248acf4f9
Submitter: Zuul
Branch: R3.0

commit 42d37d3b08749c651b9c81d219c47ae248acf4f9
Author: Ananth Suryanarayana <email address hidden>
Date: Tue Oct 11 13:48:32 2016 -0700

Use correct DB partition when looking up for a particular prefix

Multiple instances are launched in parallel, who all querty for the prefix.
Only one which maps to the prefix's partition should look up in that partition
and find the route, if present.

Change-Id: Iae4fac20c95a2ffa802fb92ac05ceecaaa96c4e5
Closes-Bug: 1632519

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/24819
Committed: http://github.org/Juniper/contrail-controller/commit/fcaebd48ef49986a59e47f6abecb3acc26abd798
Submitter: Zuul
Branch: R3.1

commit fcaebd48ef49986a59e47f6abecb3acc26abd798
Author: Ananth Suryanarayana <email address hidden>
Date: Tue Oct 11 13:48:32 2016 -0700

Use correct DB partition when looking up for a particular prefix

Multiple instances are launched in parallel, who all querty for the prefix.
Only one which maps to the prefix's partition should look up in that partition
and find the route, if present.

Change-Id: Iae4fac20c95a2ffa802fb92ac05ceecaaa96c4e5
Closes-Bug: 1632519

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.2

Review in progress for https://review.opencontrail.org/25186
Submitter: Nischal Sheth (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/25186
Committed: http://github.org/Juniper/contrail-controller/commit/aa93199978c03025280e3b965982199ae9455a50
Submitter: Zuul
Branch: R3.2

commit aa93199978c03025280e3b965982199ae9455a50
Author: Nischal Sheth <email address hidden>
Date: Wed Oct 12 10:28:15 2016 -0700

Fix concurrency issues in caching string representation

Caching the representation in a lazy manner when ToString/ToUVE
etc. are called is prone to concurrency issues. Initialize the
string representation in the constructors for the following:

- String representation for BgpPeer ToString and ToUVEKey
- String representation for InetRoute and Inet6Route ToString
- String representation for XmppConnection ToUVEKey

Change-Id: I01df9271d76a4c03977f1cc0618f97179f283999
Closes-Bug: 1632519

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/24822
Committed: http://github.org/Juniper/contrail-controller/commit/30f9def9e977387628d1abb9b3626027f35feab5
Submitter: Zuul
Branch: master

commit 30f9def9e977387628d1abb9b3626027f35feab5
Author: Nischal Sheth <email address hidden>
Date: Wed Oct 12 10:28:15 2016 -0700

Fix concurrency issues in caching string representation

Caching the representation in a lazy manner when ToString/ToUVE
etc. are called is prone to concurrency issues. Initialize the
string representation in the constructors for the following:

- String representation for BgpPeer ToString and ToUVEKey
- String representation for InetRoute and Inet6Route ToString
- String representation for XmppConnection ToUVEKey

Change-Id: I01df9271d76a4c03977f1cc0618f97179f283999
Closes-Bug: 1632519

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.2

Review in progress for https://review.opencontrail.org/25239
Submitter: Ananth Suryanarayana (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/24803
Committed: http://github.org/Juniper/contrail-controller/commit/b63a0afa052b6839da4d7a50a4be8b026185a5bd
Submitter: Zuul
Branch: master

commit b63a0afa052b6839da4d7a50a4be8b026185a5bd
Author: Ananth Suryanarayana <email address hidden>
Date: Tue Oct 11 13:48:32 2016 -0700

Use correct DB partition when looking up for a particular prefix

Multiple instances are launched in parallel, who all querty for the prefix.
Only one which maps to the prefix's partition should look up in that partition
and find the route, if present.

Change-Id: Iae4fac20c95a2ffa802fb92ac05ceecaaa96c4e5
Closes-Bug: 1632519

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/25239
Committed: http://github.org/Juniper/contrail-controller/commit/694d3e30b207176d3e1f7619f3aaf4e6e61ff04e
Submitter: Zuul
Branch: R3.2

commit 694d3e30b207176d3e1f7619f3aaf4e6e61ff04e
Author: Ananth Suryanarayana <email address hidden>
Date: Tue Oct 11 13:48:32 2016 -0700

Use correct DB partition when looking up for a particular prefix

Multiple instances are launched in parallel, who all querty for the prefix.
Only one which maps to the prefix's partition should look up in that partition
and find the route, if present.

Change-Id: Iae4fac20c95a2ffa802fb92ac05ceecaaa96c4e5
Closes-Bug: 1632519

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.