UX: Bullets in Launch Instance Wizard don't have left-padding

Bug #1632103 reported by Eddie Ramirez
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
anusha

Bug Description

How to reproduce:
1. Go to Project->Instances
2. Click on the "Launch Instance" button
3. Click on the "Question mark icon" in the upper right corner (shows help)
4. There are two <ul> elements with several <li> in it. Bullets are not aligned with the other <p> elements.

Revision history for this message
Eddie Ramirez (ediardo) wrote :
Revision history for this message
Daniel Castellanos (luis-daniel-castellanos) wrote :

I don't understand how they should be aligned with the <p>, could you please elaborate more on this?

Changed in horizon:
status: New → Incomplete
Revision history for this message
Eddie Ramirez (ediardo) wrote :

The wizard help is enclosed in a div.well with a padding of 19px. All <p> elements respect that padding but the <ul> has a custom padding-left value that makes the bullets appear right next to the border of the div.well:

http://pasteboard.co/eBecn65ZN.png

anusha (anusha)
Changed in horizon:
assignee: nobody → anusha (anusha)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/406564

Changed in horizon:
status: Incomplete → In Progress
Revision history for this message
anusha (anusha) wrote :

UX: Bullets in Launch Instance Wizard don't have left-padding

I have fixed the above bug, now it is working fine and it has left padding with Bullets.
Closes-Bug: #1632103

Review link : https://review.openstack.org/406564

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/406879

Revision history for this message
anusha (anusha) wrote :

UX: Bullets in Launch Instance Wizard don't have left-padding

I have fixed the above bug, now it is working fine and it has left padding with Bullets.
Closes-Bug: #1632103

Review link : https://review.openstack.org/#/c/406879/

Revision history for this message
siva (ramoju) wrote :

In the last commit we made a mistake by changing the static file , now we have resolved the mistake
by changing the openstack dashboard folder in themes folder we change the custom css ( openstack_dashboard/themes/default/_styles.scss) file.

we solve UX: Bullets in Launch Instance Wizard don't have left-padding

Review link : https://review.openstack.org/#/c/406879/

Changed in horizon:
milestone: none → ocata-2
importance: Undecided → Low
tags: added: newton-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/406879
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=964719507882dada12d0fe63b9e29bf403f06ad8
Submitter: Jenkins
Branch: master

commit 964719507882dada12d0fe63b9e29bf403f06ad8
Author: anu <email address hidden>
Date: Mon Dec 5 15:55:58 2016 +0530

    UX: Bullets in Launch Instance Wizard don't have left-padding

    I have fixed the above bug, now it is working fine and it has left padding with Bullets.
    Closes-Bug: #1632103

    Change-Id: I67338348fe160f634d19439a810d9d6853a59cc3

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 11.0.0.0b2

This issue was fixed in the openstack/horizon 11.0.0.0b2 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by anusha (<email address hidden>) on branch: master
Review: https://review.openstack.org/406564
Reason: duplicate

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/420767

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/newton)

Reviewed: https://review.openstack.org/420767
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=551e20689728afd1f6f41c878e4fb98b17cbbe7f
Submitter: Jenkins
Branch: stable/newton

commit 551e20689728afd1f6f41c878e4fb98b17cbbe7f
Author: anu <email address hidden>
Date: Mon Dec 5 15:55:58 2016 +0530

    UX: Bullets in Launch Instance Wizard don't have left-padding

    I have fixed the above bug, now it is working fine and it has left padding with Bullets.
    Closes-Bug: #1632103

    Change-Id: I67338348fe160f634d19439a810d9d6853a59cc3
    (cherry picked from commit 964719507882dada12d0fe63b9e29bf403f06ad8)

tags: added: in-stable-newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 10.0.2

This issue was fixed in the openstack/horizon 10.0.2 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.