GPT labels still being missed on storage nodes with older udev

Bug #1631949 reported by Paul Bourke
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla
Fix Released
High
Paul Bourke
Newton
Won't Fix
High
Unassigned
Ocata
Fix Released
High
Paul Bourke

Bug Description

As part of change I362b3f8e91de79687fc84e256996fbcaf303b6af a check was added to use udev to read GPT labels only if the version of udev installed supports that, otherwise fallback to sgdisk.

Unfortunately the check for udev version is unreliable, as it is returning the version of the udev userspace tools installed within the container rather than on the host.

As well as this, we're seeing the find_disks.py having trouble reading the UUID of a partition via udev. The test system is Oracle VM 3.4.2 which was released earlier this year, but has an old udev (derivative of RHEL 6).

Even if we use Ansible to query the host's version of udev and pass that through to the container, querying the above disk attributes is a lottery on older systems without a reliable reference of which versions of udev support which operations. Hence we should give operators a reliable way to toggle it's usage.

Changed in kolla:
milestone: none → newton-rc2
importance: Undecided → Critical
importance: Critical → High
assignee: nobody → Paul Bourke (pauldbourke)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla (master)

Fix proposed to branch: master
Review: https://review.openstack.org/384496

Changed in kolla:
status: New → In Progress
Steven Dake (sdake)
Changed in kolla:
milestone: newton-rc2 → ocata-1
description: updated
description: updated
Changed in kolla:
milestone: ocata-1 → ocata-2
Changed in kolla:
milestone: ocata-2 → ocata-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (master)

Reviewed: https://review.openstack.org/384496
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=dc0c07e0bf54cd461799716be438c708841d386e
Submitter: Jenkins
Branch: master

commit dc0c07e0bf54cd461799716be438c708841d386e
Author: Paul Bourke <email address hidden>
Date: Wed Nov 16 14:12:38 2016 +0000

    Add a 'fallback mode' to disable udev in find_disks

    As part of change I362b3f8e91de79687fc84e256996fbcaf303b6af a check was
    added to use udev to read GPT labels only if the version of udev
    installed supports that, otherwise fallback to sgdisk.

    Unfortunately the check for udev version is unreliable, as it is
    returning the version of the udev userspace tools installed within the
    container rather than on the host.

    As well as this, we're seeing the find_disks.py having trouble reading
    the UUID of a partition via udev. The test system is Oracle VM 3.4.2
    which was released earlier this year, but has an old udev (derivative of
    RHEL 6).

    Even if we use Ansible to query the host's version of udev and pass that
    through to the container, querying the above disk attributes is a
    lottery on older systems without a reliable reference of which versions
    of udev support which operations. Hence we should give operators a
    reliable way to toggle it's usage.

    Partial-Bug: 1631949
    Change-Id: I6ad7825cdb164498f3d02f2ae064c7c1c38e10d5

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 4.0.0.0b3

This issue was fixed in the openstack/kolla-ansible 4.0.0.0b3 development milestone.

Changed in kolla:
milestone: ocata-3 → ocata-rc1
Changed in kolla:
milestone: ocata-rc1 → pike-1
Changed in kolla:
milestone: pike-2 → pike-3
Revision history for this message
Jeffrey Zhang (jeffrey4l) wrote :

ocata branch is already fixed.

Changed in kolla:
milestone: pike-3 → pike-rc1
Changed in kolla:
milestone: pike-rc1 → queens-1
Changed in kolla:
milestone: queens-2 → queens-3
Changed in kolla:
milestone: queens-3 → queens-rc1
Changed in kolla:
milestone: queens-rc1 → queens-rc2
Changed in kolla:
milestone: queens-rc2 → rocky-1
Changed in kolla:
milestone: rocky-2 → rocky-3
Changed in kolla:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.