Amp agent sometimes returns 404 on startup

[Michael Johnson]

The amphora agent sometimes returns a 404 response when it is still starting up.

2016-10-06 03:24:32.145 21979 WARNING octavia.amphorae.drivers.haproxy.rest_api_driver [-] Could not connect to instance. Retrying.
2016-10-06 03:24:33.149 21979 WARNING octavia.amphorae.drivers.haproxy.rest_api_driver [-] Could not connect to instance. Retrying.
2016-10-06 03:24:34.594 21979 DEBUG octavia.amphorae.drivers.haproxy.rest_api_driver [-] Connected to amphora. Response: <Response [404]> request /opt/stack/new/octavia/octavia/amphorae/drivers/haproxy/rest_api_driver.py:270

This causes the request to fail and a revert.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/383940

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/383940
Committed: https://git.openstack.org/cgit/openstack/octavia/commit/?id=64670459d962e4dd8ecb35e45911dbf8398e4553
Submitter: Jenkins
Branch: master

commit 64670459d962e4dd8ecb35e45911dbf8398e4553
Author: Michael Johnson <email address hidden>
Date: Fri Oct 7 21:16:58 2016 +0000

    Fix revert on 404 from amphora agent startup

    When the amphora agent is starting up, it will return 404 until
    the startup is complete. This patch adds one retry when the driver
    receives a 404 back from the agent to allow time for it to finish
    starting.

    Change-Id: Idcf666dc508d77fb1eb1d46acdaa1b4afa278b8c
    Closes-Bug: #1631525

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/octavia 0.10.0 release.