stable/newton jobs can't upload images to glance

[Ben Nemec]

All of our stable/newton jobs are failing on an error uploading the overcloud images to glance:

MissingSchema: Invalid URL 'x/v1/images/detail?limit=20': No schema supplied. Perhaps you meant http://x/v1/images/detail?limit=20?

In the debug output, I see:

uploading overcloud images to glance
Instantiating image client: <class 'glanceclient.v1.client.Client'>
Using auth plugin: token_endpoint
Using parameters {'url': 'x', 'token': '***', 'project_name': 'admin'}

So for some reason we are passing 'x' as the url. Switching to glance v2 results in the same error, except with v2 in the path.

[Ben Nemec (bnemec)]

This may have to do with the transition to osc_lib. I see there is a call to it around the time where the bogus path first gets logged.

image = utils.find_resource(self.app.client_manager.image.images,
                                        name)

[Ben Nemec (bnemec)]

The overcloud image upload command has an auth_required=False attribute, which is incorrect since it talks to Glance. This causes osc-lib to not populate the auth data in the glance client, which is why we get the bogus 'x' url.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/382656

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/382658

[Ben Nemec (bnemec)]

I don't know how this isn't breaking master too, but there's some weirdness with the build date on the osc-lib package installed on the undercloud in the master jobs so I'm wondering if it's still using an older version that doesn't check auth_required. This would be related to why the undercloud install prompts for a password too (which it still does, last I checked).

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/382658
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=34590cc25b28581d964c68e459bd3a01b2cce4ec
Submitter: Jenkins
Branch: stable/newton

commit 34590cc25b28581d964c68e459bd3a01b2cce4ec
Author: Ben Nemec <email address hidden>
Date: Wed Oct 5 22:01:28 2016 +0000

    Remove auth_required=False from upload image command

    This command talks to glance, and as such it does in fact require
    authentication details. With auth_required set to false, osc-lib
    doesn't populate the auth details of the glance client which causes
    the attached bug.

    Change-Id: Ib7a28587a09e16819aad62d9ec123a286fd5c6a8
    Closes-Bug: 1630743
    (cherry picked from commit a3f7a787f2a7ec5a023903faff655a1fa65951b9)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/382656
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=a3f7a787f2a7ec5a023903faff655a1fa65951b9
Submitter: Jenkins
Branch: master

commit a3f7a787f2a7ec5a023903faff655a1fa65951b9
Author: Ben Nemec <email address hidden>
Date: Wed Oct 5 22:01:28 2016 +0000

    Remove auth_required=False from upload image command

    This command talks to glance, and as such it does in fact require
    authentication details. With auth_required set to false, osc-lib
    doesn't populate the auth details of the glance client which causes
    the attached bug.

    Change-Id: Ib7a28587a09e16819aad62d9ec123a286fd5c6a8
    Closes-Bug: 1630743

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 5.3.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 5.5.0 release.