OpenStack Compute (nova)

online_data_migrations does not ignore deleted services

Bug #1630732 reported by Matthew Thode
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Won't Fix
Undecided
Dan Smith
Mitaka
Fix Released
High
Dan Smith
Newton
Fix Committed
High
Dan Smith

Bug Description

I have a deleted service (nova-network) that is preventing online_data_migrations from running.

2016-10-05 00:08:30.989 14688 ERROR nova.db.sqlalchemy.api [req-47dc2ac8-3c1f-4841-bf44-7a082fc3a3ef - - - - -] Data migrations for PciDevice are not safe, likely because not all services that access the DB directly are updated to the latest version

See original description
Matthew Thode (prometheanfire)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/382639

Augustina Ragwitz (auggy)
tags: added: newton-backport-potential
Changed in nova:
status: New → In Progress
assignee: nobody → Dan Smith (danms)
Matt Riedemann (mriedem)
Changed in nova:
status: In Progress → Won't Fix
Matthew Thode (prometheanfire)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/newton)

Reviewed: https://review.openstack.org/382639
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=fb17be18cd0001f58ff5aae883b61c02a9342f88
Submitter: Jenkins
Branch: stable/newton

commit fb17be18cd0001f58ff5aae883b61c02a9342f88
Author: Dan Smith <email address hidden>
Date: Wed Oct 5 12:54:22 2016 -0700

    Fix binary name used in the pci device online migration check

    The should_migrate_data() method used to gate PCIDevice online migrations
    has, unfortunately, been incorrect since day one. It checks for the
    nova-api service, but should have been checking for nova-osapi_compute.
    This fixes that and adds a test.

    Change-Id: I69faa52fc126db6e99827bcb7dcf0841d0e15e74
    Closes-Bug: #1630732

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/385195

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 14.0.1

This issue was fixed in the openstack/nova 14.0.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/mitaka)

Reviewed: https://review.openstack.org/385195
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=edbd3135f8087ea73dc73b06962bf8b869ee6f43
Submitter: Jenkins
Branch: stable/mitaka

commit edbd3135f8087ea73dc73b06962bf8b869ee6f43
Author: Dan Smith <email address hidden>
Date: Wed Oct 5 12:54:22 2016 -0700

    Fix binary name used in the pci device online migration check

    The should_migrate_data() method used to gate PCIDevice online migrations
    has, unfortunately, been incorrect since day one. It checks for the
    nova-api service, but should have been checking for nova-osapi_compute.
    This fixes that and adds a test.

    Change-Id: I69faa52fc126db6e99827bcb7dcf0841d0e15e74
    Closes-Bug: #1630732
    (cherry picked from commit fb17be18cd0001f58ff5aae883b61c02a9342f88)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 13.1.3

This issue was fixed in the openstack/nova 13.1.3 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.