Fuel for OpenStack

Default custom graph filter is empty leading to error-prone UX

Bug #1630605 reported by Vladimir Kuklin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Invalid
High
Vladimir Kuklin
Fuel for OpenStack 11.0
Mitaka
Fix Released
High
Vladimir Kuklin
Fuel for OpenStack 9.2
Newton
Invalid
High
Vladimir Kuklin
Fuel for OpenStack 10.1

Bug Description

Currently in 9.1 and master we have an issue with custom graph UX that leads to the situation when a custom graph without node filter is considered to be executed on all the online nodes. Instead, we should set default node_filter to be equal to the one of deployment graphs, e.g for provisioned/ready/stopped nodes or nodes in error_type = deploy status. Otherwise, old graphs for 9.0 become barely usable without updates.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/382471

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/382504

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/382471
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=64fce5225785f08381ac52ff2636aebb2ac21ac9
Submitter: Jenkins
Branch: master

commit 64fce5225785f08381ac52ff2636aebb2ac21ac9
Author: Bulat Gaifullin <email address hidden>
Date: Wed Oct 5 17:42:34 2016 +0300

    Added default node filter

    If graph does not contain node_filter the default filter
    will be used. this will help to improve UX when user works
    with graph concept.

    Change-Id: I237189436b4ed5dd64ef6d60a05c674d2f974eb4
    Closes-Bug: 1630605

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/385557

Changed in fuel:
assignee: Bulat Gaifullin (bgaifullin) → Vladimir Kuklin (vkuklin)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-web (master)

Change abandoned by Vladimir Kuklin (<email address hidden>) on branch: master
Review: https://review.openstack.org/385557

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-web (stable/mitaka)

Related fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/385902

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/fuel-web 10.0.0rc1

This issue was fixed in the openstack/fuel-web 10.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-web (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/386973

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-web (stable/mitaka)

Related fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/387090

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/386973
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=4e1b7030dcf1f803cebdd7cfcf1979025a133a7d
Submitter: Jenkins
Branch: master

commit 4e1b7030dcf1f803cebdd7cfcf1979025a133a7d
Author: Bulat Gaifullin <email address hidden>
Date: Sat Oct 15 23:46:39 2016 +0300

    Transactions manager uses custom node serialization

    In transaction manager we need some custom node
    serializer, since there is different number of fields
    and raw status of node instead of calculated status of node.
    So the new NodeSerializerForDeployment was introduced.

    Change-Id: Id78a8549a293c98acf0bcd0d4c174e551ecf666a
    Related-Bug: 1630605

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-web (stable/mitaka)

Reviewed: https://review.openstack.org/387090
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=415c4e1316b7c8f354080c5710e32a4dd55f9b54
Submitter: Jenkins
Branch: stable/mitaka

commit 415c4e1316b7c8f354080c5710e32a4dd55f9b54
Author: Bulat Gaifullin <email address hidden>
Date: Sat Oct 15 23:46:39 2016 +0300

    Transactions manager uses custom node serialization

    In transaction manager we need some custom node
    serializer, since there is different number of fields
    and raw status of node instead of calculated status of node.
    So the new NodeSerializerForDeployment was introduced.

    Change-Id: Id78a8549a293c98acf0bcd0d4c174e551ecf666a
    Related-Bug: 1630605

tags: added: in-stable-mitaka
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-web (stable/newton)

Related fix proposed to branch: stable/newton
Review: https://review.openstack.org/394878

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-web (stable/mitaka)

Change abandoned by Vladimir Kuklin (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/385902

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/fuel-web 10.0.0

This issue was fixed in the openstack/fuel-web 10.0.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/409114

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (stable/mitaka)

Reviewed: https://review.openstack.org/382504
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=d6be7c6e24da3ed74294e1bd7bdb187095e012fc
Submitter: Jenkins
Branch: stable/mitaka

commit d6be7c6e24da3ed74294e1bd7bdb187095e012fc
Author: Bulat Gaifullin <email address hidden>
Date: Wed Oct 5 17:42:34 2016 +0300

    Added default node filter

    If graph does not contain node_filter the default filter
    will be used. this will help to improve UX when user works
    with graph concept.

    Change-Id: I237189436b4ed5dd64ef6d60a05c674d2f974eb4
    Closes-Bug: 1630605

TatyanaGladysheva (tgladysheva)
tags: added: on-verification
Revision history for this message
TatyanaGladysheva (tgladysheva) wrote :

Verified on 9.2 snapshot #651.

tags: removed: on-verification
Dmitry Pyzhov (dpyzhov)
Changed in fuel:
milestone: 10.0 → 11.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-web (stable/newton)

Reviewed: https://review.openstack.org/394878
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=00c0a5247995c51ed08f7fe6270577d4b25f2b4b
Submitter: Jenkins
Branch: stable/newton

commit 00c0a5247995c51ed08f7fe6270577d4b25f2b4b
Author: Bulat Gaifullin <email address hidden>
Date: Sat Oct 15 23:46:39 2016 +0300

    Transactions manager uses custom node serialization

    In transaction manager we need some custom node
    serializer, since there is different number of fields
    and raw status of node instead of calculated status of node.
    So the new NodeSerializerForDeployment was introduced.

    Change-Id: Id78a8549a293c98acf0bcd0d4c174e551ecf666a
    Related-Bug: 1630605
    (cherry picked from commit 4e1b7030dcf1f803cebdd7cfcf1979025a133a7d)

tags: added: in-stable-newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-web (stable/newton)

Change abandoned by Vladimir Kuklin (<email address hidden>) on branch: stable/newton
Review: https://review.openstack.org/409114

Vladimir Kuklin (vkuklin)
Changed in fuel:
status: In Progress → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.