[OCF] mysql fails to start if we have own bash script in /etc/profile.d

[Michael Kraynov]

During mysql start there is a check which is using "sh" shell.
The check is done on line 672 of "/usr/lib/ocf/resource.d/fuel/mysql-wss".
And that will, according to "/etc/profiles", start everything in "/etc/profile.d/"

if [ -d /etc/profile.d ]; then
for i in /etc/profile.d/*.sh; do
if [ -r $i ]; then
. $i
fi
done
unset i
fi

The problem is that if there is anything inside that directory which works only with "bash" execution, it fails, and MySQL does not start.

Expected results:
MySQL OCF script should ignore other scripts or work with bash execution.

Description of the environment:
Mirantis OpenStack 9.0

[Alexander Rubtsov (arubtsov)]

sla2 for 9.0-updates

[Michael Kraynov (mkraynov)]

Hello there is a small recomendation for fix the issue:

In the MySQL OCF script, instead of starting a shell and using the internal test, it would be better to call /usr/bin/test

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/391215

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/391215
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=594842a63e7729d514bd658a38d615b32190ac25
Submitter: Jenkins
Branch: master

commit 594842a63e7729d514bd658a38d615b32190ac25
Author: Oleksiy Molchanov <email address hidden>
Date: Thu Oct 27 17:20:00 2016 +0300

    Change approach how to check whether directory is writable

    Closes-Bug: 1630561
    Change-Id: I4af7d480cc4481ffa8c91a599aec2458f4124d6f

[Alexander Rubtsov (arubtsov)]

The fix has been merged to master, however Launchpad attributes show status "Fix committed" against 9.2 milestone. I'm going to back status for 9.2 to "confirmed" since we still need backport for customer

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/395519

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/395520

[OpenStack Infra (hudson-openstack)]

Change abandoned by Oleksiy Molchanov (<email address hidden>) on branch: stable/newton
Review: https://review.openstack.org/395519

[OpenStack Infra (hudson-openstack)]

Change abandoned by Oleksiy Molchanov (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/395520

[Oleksiy Molchanov (omolchanov)]

Reverting existing patch, marking as confirmed.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/397207

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/397212

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/397213

[OpenStack Infra (hudson-openstack)]

Change abandoned by Oleksiy Molchanov (<email address hidden>) on branch: stable/newton
Review: https://review.openstack.org/395519

[OpenStack Infra (hudson-openstack)]

Change abandoned by Oleksiy Molchanov (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/395520

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/397207
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=21cca3d9730a246ba2f4131288a1ead3e549d28e
Submitter: Jenkins
Branch: master

commit 21cca3d9730a246ba2f4131288a1ead3e549d28e
Author: Oleksiy Molchanov <email address hidden>
Date: Mon Nov 14 16:15:49 2016 +0200

    Change approach how to check whether directory is writable

    Change-Id: Ice7c8f964246f4abd3619906aa4404ea826a9606
    Closes-Bug: 1630561

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/397212
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=7508e060558430d1c9e17805b0868e9608fdf51e
Submitter: Jenkins
Branch: stable/newton

commit 7508e060558430d1c9e17805b0868e9608fdf51e
Author: Oleksiy Molchanov <email address hidden>
Date: Mon Nov 14 16:15:49 2016 +0200

    Change approach how to check whether directory is writable

    Change-Id: Ice7c8f964246f4abd3619906aa4404ea826a9606
    Closes-Bug: 1630561

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/397213
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=fcd091a3374db46d23d8910f28200bdef5242735
Submitter: Jenkins
Branch: stable/mitaka

commit fcd091a3374db46d23d8910f28200bdef5242735
Author: Oleksiy Molchanov <email address hidden>
Date: Mon Nov 14 16:15:49 2016 +0200

    Change approach how to check whether directory is writable

    Change-Id: Ice7c8f964246f4abd3619906aa4404ea826a9606
    Closes-Bug: 1630561

[TatyanaGladysheva (tgladysheva)]

Verified on 9.2 snapshot #580.

Steps to verify:
1) Deploy the environment: 1 controller + 1 compute with cinder.
2) Create new file test.sh with any content (in my case it was python script) in /etc/profile.d folder
3) crm resource stop clone_p_mysqld
4) crm resource stop clone_p_mysqld
5) ps axuf | grep mysql, observe /var/log/mysql/mysqld.log

Actual result:
Mysql starts successfully: https://paste.mirantis.net/show/2826/

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/fuel-library 11.0.0.0rc1 release candidate.