Arnold detention crashes when switch reports SNMP agent error

[Morten Brekkevold]

As observed on a client installation, when attempting to run a manual detention operation against a switch, the the switch respons with an SNMP error - and Arnold crashes with a traceback as it attempts to handle the error.

The mailed traceback looks like this:

Internal Server Error: /arnold/manualdetention/XXX.XXX.XXX.XXX
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/django/core/handlers/base.py", line 111, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/usr/lib/python2.7/dist-packages/nav/web/arnold/views.py", line 246, in render_manual_detention_step_two
    error = process_manual_detention_form(form, get_account(request))
  File "/usr/lib/python2.7/dist-packages/nav/web/arnold/views.py", line 304, in process_manual_detention_form
    autoenablestep=days)
  File "/usr/lib/python2.7/dist-packages/nav/arnold.py", line 275, in disable
    change_port_status('disable', identity)
  File "/usr/lib/python2.7/dist-packages/nav/arnold.py", line 436, in change_port_status
    except nav.Snmp.AgentError, why:
AttributeError: 'module' object has no attribute 'AgentError'

[Morten Brekkevold (mbrekkevold)]

fix here: https://nav.uninett.no/hg/nav/rev/0bbb8094b4af