Kernel / Ramdisk not set when registering nodes with the UI

[Julie Pichon]

Using Newton, UI version is 20160930145215.f7297c3. It seems the UI doesn't set a kernel and ramdisk name by default. After registering the nodes, looking at ironic node-list --detail I only see this sort of information:

{u'ipmi_address': u'192.168.101.60', u'ipmi_username': u'admin', u'ipmi_password': u'******'}

While when registering via the CLI using the same nodes.json file I get:

{u'ipmi_password': u'******', u'ipmi_address': u'192.168.101.60', u'deploy_ramdisk': u'49418005-d286-4c97-96eb-f2fa39467aeb', u'deploy_kernel': u'da9ebb29-d421-4025-ab35-324481b24548', u'ipmi_username': u'admin'}

I think this is happening because the workflow doesn't set the kernel name and ramdisk name by default:

https://github.com/openstack/tripleo-common/blob/7ee661/workbooks/baremetal.yaml#L35

This was to allow the CLI import commands to still work with the '--no-deploy-image' parameter when using Mistral. The CLI otherwise hardcodes the kernel and ramdisk names:

https://github.com/openstack/python-tripleoclient/blob/133e8c/tripleoclient/v1/overcloud_node.py#L190
https://github.com/openstack/python-tripleoclient/blob/133e8c/tripleoclient/v1/baremetal.py#L132

I think the UI needs to do the same thing, probably around:

https://github.com/openstack/tripleo-ui/blob/29e95e/src/js/actions/RegisterNodesActions.js#L46

I suspect not having this set may cause issues down the line, and since we're trying to keep the UI and CLI in sync we probably want to make sure nodes are registered with the same defaults. (I can't test an actual deployment in that environment at the moment due to other issues I'm debugging - if this affects deployments the bug importance likely needs to be raised)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/381855

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/381855
Committed: https://git.openstack.org/cgit/openstack/tripleo-ui/commit/?id=a9408ec5124625365272f1ca94da0f73eb208fb7
Submitter: Jenkins
Branch: master

commit a9408ec5124625365272f1ca94da0f73eb208fb7
Author: Jiri Tomasek <email address hidden>
Date: Tue Oct 4 15:50:56 2016 +0200

    Add image names to Nodes registration workflow

    This change hardcodes kernel and ramdisk image names
    to Nodes registration workflow input

    Closes-Bug: #1630222
    Change-Id: I425145ea5de3ee572527e1cacaecdfd8c3376570

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/382785

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/382785
Committed: https://git.openstack.org/cgit/openstack/tripleo-ui/commit/?id=c1bbe9ab82b02f2698b689eaf59cc34b22e40788
Submitter: Jenkins
Branch: stable/newton

commit c1bbe9ab82b02f2698b689eaf59cc34b22e40788
Author: Jiri Tomasek <email address hidden>
Date: Tue Oct 4 15:50:56 2016 +0200

    Add image names to Nodes registration workflow

    This change hardcodes kernel and ramdisk image names
    to Nodes registration workflow input

    Closes-Bug: #1630222
    Change-Id: I425145ea5de3ee572527e1cacaecdfd8c3376570
    (cherry picked from commit a9408ec5124625365272f1ca94da0f73eb208fb7)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-ui 1.0.4 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-ui 2.0.0 release.