Moving a tab quickly when there are many tabs open, sometimes causes tab to left in a incorrect position
Bug #1630211 reported by
Andrew Hayzen
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| webbrowser-app (Ubuntu) |
In Progress
|
Low
|
Andrew Hayzen | ||
Bug Description
What happened:
1) Open the webbrowser and many tabs
2) Select the first tab
3) Drag the tab quickly from the left side to the right
4) Notice that as you are dragging the tab lags and is sometimes left at a previous position (not the end)
What I expected to happen:
At step 4 for the tab to be in the correct position.
This occurs because the tab move() only moves +/- 1 at any time, and is performed onXChanged. Which occurs from the animation of the change X position from the mouse. However if you move fast enough the animation skips certain values, causing some moves to be missed.
Related branches
lp:~ahayzen/webbrowser-app/fix-1630211-drag-tabs-quickly-incorrect-position
- Andrew Hayzen (community): Disapprove
- system-apps-ci-bot: Needs Fixing (continuous-integration)
- Ubuntu Phablet Team: Pending requested
-
Diff: 98 lines (+51/-14)3 files modifiedsrc/app/webbrowser/TabsBar.qml (+17/-6)
src/app/webbrowser/tabs-model.cpp (+19/-3)
tests/unittests/tabs-model/tst_TabsModelTests.cpp (+15/-5)
| Changed in webbrowser-app (Ubuntu): | |
| assignee: | nobody → Andrew Hayzen (ahayzen) |
| status: | New → In Progress |
Revision history for this message
| Olivier Tilloy (osomon) wrote | #1 |
| Changed in webbrowser-app (Ubuntu): | |
| importance: | Undecided → Low |
To post a comment you must log in.
I can reliably reproduce the issue with many tabs open.
This is mitigated by the fact that if you keep the mouse button pressed and start moving the tab again after its position got out of sync with your cursor, it will re-position itself to follow the cursor again.