The Widelands installer should ask for admin privileges when installed into C:\Programs

[Kyromaster]

I installed the appveyor generated build 1228 on my computer.
However when starting it I see "the application has requested the Runtime to terminate in an unusual way".
I tried both debug and release builds but I get the same message.
I've a Lenovo MIIX 300 Netbook with Windows 10 x32 and an Intel HD Graphics (Bay Trail).
What can I do to help debugging?

[SirVer (sirver)]

Thanks for reporting this!

Which OS is this?

I assume this is a duplication of https://bugs.launchpad.net/widelands/+bug/1536377 which remains a mystery for the moment.

Next to widelands.exe should be the output of the whole program (called stdout.txt IIRC). Could you look at its contents? Also, starting widelands from the cmd.exe prompt will give you more information.

[Kyromaster (kyromaster)]

I use windows 10
I figured it out: it's related to administrator privilegies
Running widelands.exe as administrator and it works. But no idea why it requires admin rights...

[SirVer (sirver)]

does this also happen with tinos nightlies?
https://widelands.8-schuss.de/

[Kyromaster (kyromaster)]

I can't test since these are x64 and I'm on x86

[Tino (tino79)]

This is a known restriction:
Widelands does not need administrator privilegies and so the installer does not ask for them and suggests an installation dir which does not require elevated rights.

If you explicitely start the installer with elevated rights and install to a restricted path (e.g. c:\Program Files) you also need to run widelands with elevated rights because it writes a logfile at runtime to the same dir as the executable resides in.

[Kyromaster (kyromaster)]

This isn't true with my system.
It wants to install into "C:\Programme\Widelands" which is IMHO the right place for programs.

[Tino (tino79)]

You are partly right. This is the correct dir to install programs, but not to write data at runtime to.
What widelands does at moment (the logfile).

I do want to enable users with no admin rights to be able to install and play widelands, so I won't hardcode asking for privileges into the installer.

But for B20 we should do:
- Ask for admin privileges if the user chooses a dir which requires those (but only then)
- Do not write the logfile to wl binary dir (This should go to %USERHOME%\.widelands)

[Kyromaster (kyromaster)]

This is exactly what I wanted to suppose as a solution ;)
Perhaps even better under windows would be to store all application data to %userhome%\AppData\...

[GunChleoc (gunchleoc)]

I have tested the AppVeyor release build for the attached branch on Windows 10. The installer had to be run as administrator when installed into C:\Program Files, the game can then be run without admin privileges. stdout.txt is written to C:\Users\<username>\.widelands

Also, the uninstaller can remove the Widelands directory cleanly now, because there is no new file written into it.

[Tino (tino79)]

Innosetup does not provide a way dynamically asking for admin priviliges when the user chooses a protected installation dir (e.g. C:\Program Files).

I have no switched to {localappdata}\Widelands as default dir, which is guaranteed to be user writable.

If the user does want to install to protected dir, he has to start the installer manually as admin.

[GunChleoc (gunchleoc)]

Fixed in build20-rc1