networking-bgpvpn

bagpipe: use ROUTER_INTERFACE registry callback notifications

Bug #1629358 reported by Thomas Morin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
networking-bgpvpn
Fix Released
Low
Thomas Morin
networking-bgpvpn 6.0.0 "ocata"

Bug Description

The current code relies on Port AFTER_UPDATE notification to detect the creation/removal of router ports.

This was necessary at some point in the past because the Neutron l3 code for triggering registry callbacks was not complete yet.

The code can be simplified now that ROUTER_INTERFACE notification are triggered.

Tags: bagpipe rfe
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-bgpvpn (master)

Fix proposed to branch: master
Review: https://review.openstack.org/381091

Changed in bgpvpn:
assignee: nobody → Thomas Morin (tmmorin-orange)
status: New → In Progress
Mathieu Rohon (mathieu-rohon)
Changed in bgpvpn:
importance: Undecided → Low
milestone: none → 5.0.0
Mathieu Rohon (mathieu-rohon)
Changed in bgpvpn:
milestone: 5.0.0 → 6.0.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-bgpvpn (master)

Reviewed: https://review.openstack.org/381091
Committed: https://git.openstack.org/cgit/openstack/networking-bgpvpn/commit/?id=6dad68b260462075d1f3627b0325bb1992c2ccb1
Submitter: Jenkins
Branch: master

commit 6dad68b260462075d1f3627b0325bb1992c2ccb1
Author: Thomas Morin <email address hidden>
Date: Mon Oct 3 14:32:01 2016 +0200

    bagpipe: rely on ROUTER_INTERFACE registry callbacks

    This change replaces the code trying to detect new router
    interfaces based on PORT create/update notifications, by code simply
    listening on ROUTER_INTERFACE created/deleted notifications.

    Change-Id: Ibab3ab2adfc636d4a48775ea7e9ac7ffdf53dcdf
    Closes-Bug: 1629358

Changed in bgpvpn:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-bgpvpn (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/393636

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on networking-bgpvpn (stable/newton)

Change abandoned by Thomas Morin (<email address hidden>) on branch: stable/newton
Review: https://review.openstack.org/393636

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/networking-bgpvpn 6.0.0

This issue was fixed in the openstack/networking-bgpvpn 6.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.