Can't use logging-environment.yaml on overcloud deployment

[Juan Badia Payno]

Deploying overcloud stack with the logging client side installed does not deploy.

The overcloud-deploy.sh script was modified with the following line:

openstack overcloud deploy \
    --templates tripleo-heat-templates \
    --libvirt-type qemu --control-flavor oooq_control \
    --compute-flavor oooq_compute --ceph-storage-flavor oooq_ceph \
    --timeout 90 \
    -e tripleo-heat-templates/environments/network-isolation.yaml \
    -e tripleo-heat-templates/environments/net-single-nic-with-vlans.yaml \
    -e $HOME/network-environment.yaml \
    -e tripleo-heat-templates/environments/puppet-pacemaker.yaml \
    --neutron-network-type vxlan --neutron-tunnel-types vxlan \
    --ntp-server pool.ntp.org --ceph-storage-scale 1 \
    --compute-scale 2 --control-scale 2 \
    -e tripleo-heat-templates/environments/logging-environment.yaml
    ${DEPLOY_ENV_YAML:+-e $DEPLOY_ENV_YAML} "$@" || true

Only the below line was added:
-e tripleo-heat-templates/environments/logging-environment.yaml

When the overcloud-deploy.sh is executed the next error shows up

***
...Plan updated
Deploying templates in the directory /home/stack/tripleo-heat-templates
'NoneType' object does not support item assignment
+ true
+ openstack stack list
+ grep -q CREATE_FAILED
....
***

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/380003
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=a23f1929b743124af03aa4f72d0ed0e828fe358b
Submitter: Jenkins
Branch: master

commit a23f1929b743124af03aa4f72d0ed0e828fe358b
Author: Juan Badia Payno <email address hidden>
Date: Fri Sep 30 10:13:29 2016 +0200

    Fixed NoneType issue when logging-environment.yaml is used

    When you tried to use the environemnt/logging-environemnt.yaml
    as a part of the deployment on the overcloud you hit the
    following error and it stops the deploy of the overcloud.

    ***
    Deploying templates in the directory /home/stack/tripleo-heat-templates
    'NoneType' object does not support item assignment
    ***

    Closes-Bug: #1629315
    Change-Id: I55e5c7f20ddf30f3e48247b734f6fa47f5de3750
    Signed-off-by: Juan Badia Payno <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/383776

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/383776
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=ea2f03d5716e0516c7fe72cd3fcb7f7a09b637d4
Submitter: Jenkins
Branch: stable/newton

commit ea2f03d5716e0516c7fe72cd3fcb7f7a09b637d4
Author: Juan Badia Payno <email address hidden>
Date: Fri Sep 30 10:13:29 2016 +0200

    Fixed NoneType issue when logging-environment.yaml is used

    When you tried to use the environemnt/logging-environemnt.yaml
    as a part of the deployment on the overcloud you hit the
    following error and it stops the deploy of the overcloud.

    ***
    Deploying templates in the directory /home/stack/tripleo-heat-templates
    'NoneType' object does not support item assignment
    ***

    Closes-Bug: #1629315
    Change-Id: I55e5c7f20ddf30f3e48247b734f6fa47f5de3750
    Signed-off-by: Juan Badia Payno <email address hidden>
    (cherry picked from commit a23f1929b743124af03aa4f72d0ed0e828fe358b)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 5.0.0.0rc3 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 5.0.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 6.0.0.0b1 development milestone.