Setting node state during registration is duplicated

Bug #1628935 reported by Derek Higgins
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Derek Higgins

Bug Description

During node registration, the following sequence occurs in tripleoclient and mistral

o Get token from keystone
o POST a "register" workflow to mistral (tripleo.baremetal.v1.register_or_update)
o open a websocket to wait for the mistral workflow to finish
 - In mistral the following happens
  - for each node register it with ironic (essentially the same the the entire OSPd 9 process)
  - for each node
   - set the node provision state too manageable
   - wait for ironic to actually set the node state (1 sec sleep between checks)
   - set the node provision state too available
   - wait for ironic to actually set the node state (1 sec sleep between checks)
   - set the node provision state too manageable
o POST a "provide" workflow to mistral (tripleo.baremetal.v1.provide)
o open a websocket to wait for the mistral workflow to finish
 - In mistral the following happens
  - for each node
   - set the node provision state too available

It looks like we are duplicating the logic to set the nodes to manageable and then too available.

I believe the problem is in
http://git.openstack.org/cgit/openstack/tripleo-common/tree/workbooks/baremetal.yaml

the "register_or_update" workflow calls
   tripleo_common.actions.baremetal:RegisterOrUpdateNodes which
    registers nodes, sets them too manageable, waits for each one to set, sets each node to available and waits for the state of each node to set again
   tripleo.baremetal.v1.set_node_state which
    which sets each node back too manageable,

tripleoclient then also calls the "provide" workflow
   which sets each node to available again

This adds a lot of time to node registration, a lot of this time is mistral overhead

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (master)

Fix proposed to branch: master
Review: https://review.openstack.org/379482

Changed in tripleo:
status: Triaged → In Progress
Derek Higgins (derekh)
Changed in tripleo:
importance: Undecided → High
Changed in tripleo:
milestone: newton-rc2 → ocata-1
tags: added: newton-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (master)

Reviewed: https://review.openstack.org/379482
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=f5fce807831f22096b6c5e487e3c07edb8dd8f37
Submitter: Jenkins
Branch: master

commit f5fce807831f22096b6c5e487e3c07edb8dd8f37
Author: Derek Higgins <email address hidden>
Date: Thu Sep 29 14:54:57 2016 +0100

    Don't set node state during node registration

    The state is being set in "manageable" later in the workflow and
    then to available when tripleoclient calls the "provide" workflow.

    Change-Id: I42164d57ec37ad666698f9757f7eeab45f01cbcd
    Closes-Bug: #1628935

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/379843

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (stable/newton)

Reviewed: https://review.openstack.org/379843
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=848ec9021b5fa528b08b5e4459f461dc51dc9f7c
Submitter: Jenkins
Branch: stable/newton

commit 848ec9021b5fa528b08b5e4459f461dc51dc9f7c
Author: Derek Higgins <email address hidden>
Date: Thu Sep 29 14:54:57 2016 +0100

    Don't set node state during node registration

    The state is being set in "manageable" later in the workflow and
    then to available when tripleoclient calls the "provide" workflow.

    Change-Id: I42164d57ec37ad666698f9757f7eeab45f01cbcd
    Closes-Bug: #1628935
    (cherry picked from commit f5fce807831f22096b6c5e487e3c07edb8dd8f37)

tags: added: in-stable-newton
Steven Hardy (shardy)
Changed in tripleo:
milestone: ocata-1 → newton-rc3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 5.3.0

This issue was fixed in the openstack/tripleo-common 5.3.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 5.5.0

This issue was fixed in the openstack/tripleo-common 5.5.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.