tripleo

Mistral client now only accepts kwargs

Bug #1628853 reported by Dougal Matthews on 2016-09-29

This bug affects 3 people

Affects		Status	Importance	Assigned to	Milestone
	tripleo	Fix Released	Critical	Dougal Matthews	tripleo newton-rc2 "newton-rc2"

Bug Description

2016-09-29 09:08:07.456319 | 2016-09-29 09:08:07.000 | Traceback (most recent call last):
2016-09-29 09:08:07.456344 | 2016-09-29 09:08:07.000 | File "<string>", line 1, in <module>
2016-09-29 09:08:07.456385 | 2016-09-29 09:08:07.000 | File "/usr/lib/python2.7/site-packages/instack_undercloud/undercloud.py", line 1180, in install
2016-09-29 09:08:07.456408 | 2016-09-29 09:08:07.000 | _post_config(instack_env)
2016-09-29 09:08:07.456451 | 2016-09-29 09:08:07.000 | File "/usr/lib/python2.7/site-packages/instack_undercloud/undercloud.py", line 1161, in _post_config
2016-09-29 09:08:07.456469 | 2016-09-29 09:08:07.000 | auth_url)
2016-09-29 09:08:07.456499 | 2016-09-29 09:08:07.000 | TypeError: client() takes at most 1 argument (5 given)

From: http://logs.openstack.org/67/356567/8/check/gate-tripleo-ci-centos-7-nonha-multinode/fb8b79e/console.html#_2016-09-29_09_08_07_456499

We were broken by: https://github.com/openstack/python-mistralclient/commit/55d55bcdf1240598dd570917531f5100cedfaa73

Tags:

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-29: Fix proposed to instack-undercloud (master)

Fix proposed to branch: master
Review: https://review.openstack.org/379322

Changed in tripleo:
status:	Confirmed → In Progress

Dougal Matthews (d0ugal) on 2016-09-29

summary:

- Mistral client no longer accepts kwargs
+ Mistral client now *only* accepts kwargs

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-29: Fix merged to instack-undercloud (master)

Reviewed: https://review.openstack.org/379322
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=56e65af08467cf4542c9fde393a61bf3adc3ce42
Submitter: Jenkins
Branch: master

commit 56e65af08467cf4542c9fde393a61bf3adc3ce42
Author: Dougal Matthews <email address hidden>
Date: Thu Sep 29 10:37:37 2016 +0100

Use kwargs when creating mistralclient

    Recently in If6ff35e91c3d35c2741332c7e739bb92b1234c54 a refactor of the
    authentication in Mistral client stopped it accepting *args and now it
    only accepts **kwargs.

    kwargs were always expected, but Python will allow you to implicitly
    pass them based on the order, but as this was removed and now **kwargs
    is in the method signature it wont work.

This is a regression in mistralclient.

Closes-Bug: #1628853
Change-Id: I8b8963c97b9e8c2a31b5f554f737d95685bc330a