[2.1, FUJ] There is no validation for the Custom URL format in the Ubuntu section

Bug #1628108 reported by Maria Vrachni
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MAAS
Invalid
Low
Unassigned

Bug Description

MAAS bzr5400
[FUJ] There is no validation for the format when the users adds a URL of a Custom source in Ubuntu section.

Bug description:

* Current result:

Given I am in the Custom source of the Ubuntu section in the first use journey
When I am adding a URL with an invalid format in the Mirror URL input field
Then I can click connect, even if the Mirror URL is random text

* Expected/ correct result:

Given I am in the Custom source of the Ubuntu section in the first use journey
When I am adding a URL with an invalid format in the Mirror URL input field
Then I can see a validation error "invalid input" under the input field

And the Connect button should be disabled if the input format is invalid.

[OS X Sierra]

[Chrome, 53.0.2785.116 (64-bit)]

Tags: ui ux
Revision history for this message
Blake Rouse (blake-rouse) wrote :

Technically we do not try to validate the URL as it can also be a file path or anything that simplestreams can use to contact the source. So when you enter something invalid it will say that the source provides no "Ubuntu images", which is correct even if the URL is not valid.

tags: added: ui ux
Changed in maas:
status: New → Triaged
importance: Undecided → Low
milestone: none → 2.1.0
Revision history for this message
Andres Rodriguez (andreserl) wrote :

Actually, I think we could validate whether this is a valid path or valid URL. For example:

httpadsfasdf://images.ubuntu.com/MAAS Is not a valid URL

and:

/var/###$%$$$/images

Is not a valid PATH. Do we validate that stuff?

summary: - [FUJ] There is no validation for the Custom URL format in the Ubuntu
- section
+ [2.1, FUJ] There is no validation for the Custom URL format in the
+ Ubuntu section
Changed in maas:
importance: Low → Wishlist
importance: Wishlist → Low
Revision history for this message
Blake Rouse (blake-rouse) wrote :

Like I said, we let simplestreams handle that part. At the moment we do not validate its a valid URL, we just determine if we are able to get any source information from that given string.

Changed in maas:
milestone: 2.1.0 → 2.1.1
Changed in maas:
milestone: 2.1.1 → 2.1.2
Changed in maas:
milestone: 2.1.2 → 2.1.3
Revision history for this message
Andres Rodriguez (andreserl) wrote :

Hi!

**This is an automated message**

We believe this is may no longer be an issue in the latest MAAS release. Due to the report date of this, we are currently marking it as Invalid. If you believe this bug report still valid against the latest release of MAAS, or if you are still interested in this, please re-open this bug report.

Thanks

Changed in maas:
status: Triaged → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.