Predictable placement not interpolating %index%

[Ben Nemec]

In the scheduler hints for predictable placement we use %index% to automatically insert the correct node number at deploy time. Unfortunately, due to the composable roles work that parameter was moved from overcloud.yaml to the role files, which causes %index% to not be interpolated and thus be passed to the nova scheduler verbatim. Unsurprisingly, this does not work. :-)

It needs to be moved back to overcloud.yaml, and as a further complication the compute role's parameter is named NovaCompute so we'll need backwards compatibility logic to handle that.

For further reference, see https://bugzilla.redhat.com/show_bug.cgi?id=1379388

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/377110

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/377110
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=3d05733dd3db118a328a5fcb5199cdd0f1027ea4
Submitter: Jenkins
Branch: master

commit 3d05733dd3db118a328a5fcb5199cdd0f1027ea4
Author: Ben Nemec <email address hidden>
Date: Mon Sep 26 16:40:20 2016 -0500

    Fix predictable placement indexing

    As noted in the bug, predictable placement is broken right now
    because the %index% in the scheduler hint isn't being interpolated.
    This is because the parameter was moved from overcloud.yaml to the
    service-specific files, which doesn't provide the index value.

    Because the Compute role's parameter is named NovaCompute... we also
    have to include some backwards compatibility logic to handle the
    mismatch.

    Change-Id: Ibee2949fe4c6c707203d7250e2ce169c769b1dcd
    Closes-Bug: 1627858

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 5.0.0.0rc2 release candidate.