Juniper Openstack

Sandesh trace generated code should accept string parameters by const reference

Bug #1627430 reported by Nischal Sheth
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
Trunk
Fix Committed
Medium
mkheni
Juniper Openstack r4.1.0.0-fcs "r4.1"

Bug Description

Sandesh trace generated code should accept string parameters by const
reference instead of value. Profiling shows that we spend a fair bit
of time copying strings in the callers of sandesh trace generated
code.

See original description
Tags: analytics
Nischal Sheth (nsheth)
description: updated
Nischal Sheth (nsheth)
summary: - Sandesh trace generated code should pass string parameters by const
+ Sandesh trace generated code should accept string parameters by const
reference
description: updated
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/31762
Submitter: mkheni (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/31762
Committed: http://github.com/Juniper/contrail-sandesh/commit/ad35b75db22df6b413c6fb41e2822fcb5ca24f34
Submitter: Zuul (<email address hidden>)
Branch: master

commit ad35b75db22df6b413c6fb41e2822fcb5ca24f34
Author: mkheni <email address hidden>
Date: Wed May 17 14:49:36 2017 -0700

Sandesh trace generated code should accept string parameters by const reference instead of value as we spend a fair bit of time copying strings when passed as values.

Change-Id: If3b919a7744b8474b1bf60df5cff27e88c9a93f9
closes-bug: #1627430

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.