OS::Neutron::FloatingIP has too many dependencies

[Zane Bitter]

Now that bug 1626619 is fixed, we're once again depending on *all* RouterInterfaces that are defined in the template, instead of just the ones on Networks that we care about.

This is very similar to the issue with RouterGateway and ExtraRoutes (bug 1626630), which should be fixed first. Once it is, we can try to apply the same solution here.

The major difference with FloatingIP is that it needs to going up two levels in the graph instead of just one (FloatingIP->Port->Network and RouterInterface->Subnet->Network) to get to the shared root that we want to compare.

This would also allow us to get rid of the expensive API call mentioned in bug 1626619, which ideally has no place in the dependency calculations, without compromising the fix for bug 1428434.

See further discussion in https://review.openstack.org/#/c/289371/ for context.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/381219

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/381925

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/381925
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=de319d211ea1e064944011bd8f6d265a7fd7736e
Submitter: Jenkins
Branch: master

commit de319d211ea1e064944011bd8f6d265a7fd7736e
Author: Oleksii Chuprykov <email address hidden>
Date: Tue Oct 4 18:12:33 2016 +0300

    Add implicit deps after calculation of all explicit deps

    Now we have graph of explicit dependencies builded before calculation
    any implicit dependency in add_dependencies(). This will help to fix
    several bugs and enhance some implicit dependencies calculation in cases,
    when we need all explicit deps to be known.

    Related-Bug: #1626634

    Change-Id: Iebef2600781b867db5925346b444dec4d953aefa

[Zane Bitter (zaneb)]

Bug 1626619 is now fixed, so I updated the description to be less... future perfect.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/424033