OpenStack Dashboard (Horizon)

"Subnet" label in Create Subnet dialog is shown

Bug #1626336 reported by Yuko Katabami on 2016-09-22

This bug affects 2 people

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Dashboard (Horizon)	Fix Released	Medium	Akihiro Motoki	OpenStack Dashboard (Horizon) ocata-1 "o-1"

Bug Description

openstack_dashboard/dashboards/project/networks/subnets/workflows.py

"Subnet" label is shown as "CreateSubnetInfoAction" in Create Subnet dialog.
The original class name is shown.
An appropriate label ("Subnet" in this case) should be shown.

See original description

Tags:

Revision history for this message

Yuko Katabami (ykatabam) wrote on 2016-09-22:

UnlocalizedText_CreateSubnetTabLabel.png Edit (40.9 KiB, image/png)

zhangdetong (zhangdetong) on 2016-09-22

Changed in horizon:
assignee:	nobody → zhangdetong (zhangdetong)

zhangdetong (zhangdetong) on 2016-09-22

Changed in horizon:
assignee:	zhangdetong (zhangdetong) → nobody

Sai Kiran (saikiran) on 2016-09-22

Changed in horizon:
assignee:	nobody → Sai Kiran (saikiran)

Revision history for this message

Akihiro Motoki (amotoki) wrote on 2016-09-24:

It only happens in the Admin Network Panel. Subnet Create in Project works fine.
Admin -> Network -> Network detail -> Subnet tab -> Create Subnet

Changed in horizon:
status:	New → Confirmed
importance:	Undecided → Medium

Akihiro Motoki (amotoki) on 2016-09-24

tags:	added: newton-rc-potential
tags:	added: newton-backport-potential removed: newton-rc-potential
summary:	- "Subnet" label in Create Subnet dialog is unlocalized + "Subnet" label in Create Subnet dialog is shown
description:	updated

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-24: Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/375901

Changed in horizon:
assignee:	Sai Kiran (saikiran) → Akihiro Motoki (amotoki)
status:	Confirmed → In Progress

Akihiro Motoki (amotoki) on 2016-10-09

Changed in horizon:
milestone:	none → ocata-1

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-11-16: Fix merged to horizon (master)

Reviewed: https://review.openstack.org/375901
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=cfa9ce47e41e34f167adfa14aa6fc876d00982b7
Submitter: Jenkins
Branch: master

commit cfa9ce47e41e34f167adfa14aa6fc876d00982b7
Author: Akihiro Motoki <email address hidden>
Date: Sat Sep 24 22:56:21 2016 +0000

Show tab label in Admin CreateSubnet/UpdateSubnet form

    It seems workflows.Action does not support inheritance of Django
    Meta class. Child classes must declare Meta class again.
    Otherwise, class name is shown as a tab label in a workflow from.

Change-Id: I1bcfd2bde6238af339c2e4a4d84d6544d9c29e6b
Closes-Bug: #1626336

Changed in horizon:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-11-16: Fix proposed to horizon (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/398288

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-11-21: Fix included in openstack/horizon 11.0.0.0b1

This issue was fixed in the openstack/horizon 11.0.0.0b1 development milestone.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-11-22: Fix merged to horizon (stable/newton)

Reviewed: https://review.openstack.org/398288
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=9e9de78c7243ef3978eed7426dd832e4d878647f
Submitter: Jenkins
Branch: stable/newton

commit 9e9de78c7243ef3978eed7426dd832e4d878647f
Author: Akihiro Motoki <email address hidden>
Date: Sat Sep 24 22:56:21 2016 +0000

Show tab label in Admin CreateSubnet/UpdateSubnet form

    It seems workflows.Action does not support inheritance of Django
    Meta class. Child classes must declare Meta class again.
    Otherwise, class name is shown as a tab label in a workflow from.

    Change-Id: I1bcfd2bde6238af339c2e4a4d84d6544d9c29e6b
    Closes-Bug: #1626336
    (cherry picked from commit cfa9ce47e41e34f167adfa14aa6fc876d00982b7)