Race condition in functional tests

Bug #1626131 reported by Rodrigo Duarte
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-keystoneclient
Triaged
Low
Unassigned

Bug Description

The tests at [1] creates a race condition in the functional tests: when deleting the new role created just for the test, all user tokens are revoked - since we use the same user (via self.client) to perform other operations in different tests, these operations will fail since all tokens have been revoked.

That specific test needs an extra client created using a new user so won't affect other running tests.

This issue was uncovered by commit [2], which seems to fix our revoke events :)

[1] https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/tests/functional/v3/test_auth.py
[2] https://review.openstack.org/#/c/368244/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to python-keystoneclient (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/374211

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to python-keystoneclient (master)

Reviewed: https://review.openstack.org/374211
Committed: https://git.openstack.org/cgit/openstack/python-keystoneclient/commit/?id=ca669701f7ca8ef17d32ab7b56430cef1ce23431
Submitter: Jenkins
Branch: master

commit ca669701f7ca8ef17d32ab7b56430cef1ce23431
Author: Rodrigo Duarte Sousa <email address hidden>
Date: Wed Sep 21 11:39:28 2016 -0300

    Revert "Add auth functional tests"

    This reverts commit 2a91a41142080a4f1abb8f9846f88846c6b5c6b7.

    This is a quick fix to unblock the python-keystoneclient gate. Not
    closing the bug since we can fix the test behavior by using an extra
    client just to run the tests operations.

    Change-Id: I976488243ad3c357cd2aeb604973603380858dc4
    Related-Bug: 1626131

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to python-keystoneclient (stable/newton)

Related fix proposed to branch: stable/newton
Review: https://review.openstack.org/374466

Revision history for this message
Steve Martinelli (stevemar) wrote :

Lowering the severity since the gate is no longer broken. We should still have auth related functional tests in keystoneclient, just ones that don't cause race conditions :)

Changed in python-keystoneclient:
importance: Undecided → Low
status: New → Triaged
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to python-keystoneclient (stable/newton)

Reviewed: https://review.openstack.org/374466
Committed: https://git.openstack.org/cgit/openstack/python-keystoneclient/commit/?id=85400c93938cc721f9d8552c5b18763dc40287f6
Submitter: Jenkins
Branch: stable/newton

commit 85400c93938cc721f9d8552c5b18763dc40287f6
Author: Rodrigo Duarte Sousa <email address hidden>
Date: Wed Sep 21 11:39:28 2016 -0300

    Revert "Add auth functional tests"

    This reverts commit 2a91a41142080a4f1abb8f9846f88846c6b5c6b7.

    This is a quick fix to unblock the python-keystoneclient gate. Not
    closing the bug since we can fix the test behavior by using an extra
    client just to run the tests operations.

    Change-Id: I976488243ad3c357cd2aeb604973603380858dc4
    Related-Bug: 1626131
    (cherry picked from commit ca669701f7ca8ef17d32ab7b56430cef1ce23431)

tags: added: in-stable-newton
jessegler (je808k)
Changed in python-keystoneclient:
assignee: nobody → jessegler (je808k)
Revision history for this message
Lance Bragstad (lbragstad) wrote :

Automatically unassigning due to inactivity.

Changed in python-keystoneclient:
assignee: jessegler (je808k) → nobody
Revision history for this message
Rodrigo Duarte (rodrigodsousa) wrote :

This is something we *need* to address. It is also a nice project to introduce new contributors.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.