OVS metadata for trunk ports are not handled correctly

[Armando Migliaccio]

Caught during code review, there's issue when we add/remove subports. This makes the use of metadata totally unreliable. The error may lead to stale
OVS ports on the host when the trunk is removed.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/373600

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/373600
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=29457631ad0b77b06dee40cb5114f5f4aced129a
Submitter: Jenkins
Branch: master

commit 29457631ad0b77b06dee40cb5114f5f4aced129a
Author: Armando Migliaccio <email address hidden>
Date: Tue Sep 20 19:34:32 2016 -0700

    Update trunk metadata during wire/unwire operations

    Before this patch metadata on the OVS trunk bridge were
    not updated during unwiring operations and upon subsequent
    wire operations old subports were getting wiped from the
    external_ids field of the OVS parent port. This could lead
    to OVS ports left behind on the host on trunk removal.

    This patch ensures that the subports stored as metadata
    reflect the logical state of the trunk.

    Closes-bug: #1625875

    Change-Id: I9d885b10d84fad43c527d3ca7bc9a37439197fc9

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/374938

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/374938
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=a7be741e018c54bca0610a5881085690fc6667c5
Submitter: Jenkins
Branch: stable/newton

commit a7be741e018c54bca0610a5881085690fc6667c5
Author: Armando Migliaccio <email address hidden>
Date: Tue Sep 20 19:34:32 2016 -0700

    Update trunk metadata during wire/unwire operations

    Before this patch metadata on the OVS trunk bridge were
    not updated during unwiring operations and upon subsequent
    wire operations old subports were getting wiped from the
    external_ids field of the OVS parent port. This could lead
    to OVS ports left behind on the host on trunk removal.

    This patch ensures that the subports stored as metadata
    reflect the logical state of the trunk.

    Closes-bug: #1625875

    Change-Id: I9d885b10d84fad43c527d3ca7bc9a37439197fc9
    (cherry picked from commit 29457631ad0b77b06dee40cb5114f5f4aced129a)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 9.0.0.0rc2 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 10.0.0.0b1 development milestone.