roles_data.yaml ignores a default count of zero

[Steven Hardy]

There's a bug in the j2 syntax which means we ignore a default count of zero:

  BlockStorageCount:
    description: Number of BlockStorage nodes to deploy
    type: number

This should have default: 0 because of

- name: BlockStorage
  CountDefault: 0

but the j2 conditional doesn't evaluate true when CountDefault is zero:

  {% if role.CountDefault %}
    default: {{role.CountDefault}}
  {% endif %}

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/373994

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/373994
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=1e723337029b8ea77f12dd2d75a4a426570f1c63
Submitter: Jenkins
Branch: master

commit 1e723337029b8ea77f12dd2d75a4a426570f1c63
Author: Steven Hardy <email address hidden>
Date: Wed Sep 21 11:10:47 2016 +0100

    Make defaults from roles_data.yaml more robust

    The previous logic left out the default Count completely when it was
    zero, which breaks nested validation and it's likely similar problems
    would exist with the other optional defaults, so rework it so the
    defaulting happens in the jinja2 logic, and document the interfaces
    better in roles_data.yaml

    Change-Id: I7f2eb4a3a0b43c5d2cd0d001ed3c73f783c95c74
    Closes-Bug: #1625760

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 5.0.0.0rc2 release candidate.