Change RoutingInstances' UVE key to virtual-network

Bug #1625742 reported by Ananth Suryanarayana
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
Trunk
Fix Committed
Medium
Ananth Suryanarayana

Bug Description

Normally, a routing-instance name maps 1:1 to virtual-network. However for service-chains, 2 more routing-instances are created with auto-generated names. But the auto-generated ones also belong to a parent virtual-network. All UVEs and logs generated must use the parent virtual-network as the key (name) for easier debug-ability.

Tags: releasenote
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/24309
Submitter: Ananth Suryanarayana (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/24309
Committed: http://github.org/Juniper/contrail-controller/commit/c0f32dc23d909a5bb8b34947ba9057ce3bb428ea
Submitter: Zuul
Branch: master

commit c0f32dc23d909a5bb8b34947ba9057ce3bb428ea
Author: Ananth Suryanarayana <email address hidden>
Date: Mon Sep 19 14:51:09 2016 -0700

Update RoutingInstance table stats key to virtual_network name

o Change key from ObjectRoutingInstance to ObjectVNTable for easier debug-ability
o Always send table-stats. Sandesh library takes care of pruning stats that did
not change from last send.
o Flatten table stats list to the list of 4 families that each instance carries
and use the instance-name as the key value for the stats map
o Maintain a map of virtual-network names to a set of routing-instance names
and update this during instance creation/deletion/update
o When an instance is deleted, send explicit uve delete with table stats marked
as deleted
o When all instances under a virutal-network are deleted, delete the entire
RoutingInstanceStats which is now keyed by the name of the associated
virtual-network
o Normally, virtual-network names matches with routing-instance names. However,
for service-chains, multiple (left and right) routing-instances are created
in addition by schema-transformer. For all such instances, the stats uves are
now sent based on the associated virtual-network name as the key
o Move table stats sandesh file and its processing code to routing-instance
directory. The stats are table specific and applies to routes leanred over
both bgp and xmpp

Change-Id: I4a97b088ef14b74c3be3e7d76ec510b18d89980d
Closes-Bug: #1625742

Revision history for this message
Ananth Suryanarayana (anantha-l) wrote :

Add operational tag

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/24453
Submitter: Ananth Suryanarayana (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/24453
Committed: http://github.org/Juniper/contrail-controller/commit/4a1d32a183878d93ca491e841b7774ef633bc124
Submitter: Zuul
Branch: master

commit 4a1d32a183878d93ca491e841b7774ef633bc124
Author: Ananth Suryanarayana <email address hidden>
Date: Mon Sep 26 10:49:22 2016 -0700

Eliminate RoutingInstance::virtual_network() API

Clients should use GetVirtualNetworkName() instead.

Closes-Bug: #1625742
Change-Id: I2e5fe3d4f1638c375b54a2ea41d6c559f9898161

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.