[2.1] Need better error message when trying to add SSH keys for LP/GH user that doesn't exist
Bug #1625671 reported by
Andres Rodriguez
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| MAAS |
Fix Released
|
High
|
Newell Jensen | ||
Bug Description
Error message when trying to add keys from a non-existent LP user:
Current behavior
================
MAAS Currently shows:
"404 Client Error: Not Found for url: https:/
Expected behavior
=================
MAAS should show something similar to:
"Show "Unable to add SSH keys for MAAS user [<maas-users>] . Github user 'blah' doesn't exist"
See https:/
Related branches
lp:~newell-jensen/maas/fix-1625674-1625671-1625668
- Andres Rodriguez (community): Approve
-
Diff: 247 lines (+70/-23)6 files modifiedsrc/maasserver/api/ssh_keys.py (+3/-3)
src/maasserver/api/tests/test_api.py (+16/-3)
src/maasserver/management/commands/createadmin.py (+4/-1)
src/maasserver/tests/test_commands.py (+4/-3)
src/maasserver/utils/keys.py (+27/-10)
src/maasserver/utils/tests/test_keys.py (+16/-3)
| Changed in maas: | |
| milestone: | none → 2.1.0 |
| importance: | Undecided → High |
| status: | New → Confirmed |
| status: | Confirmed → Triaged |
| tags: | added: ssh-import |
| Changed in maas: | |
| assignee: | nobody → Newell Jensen (newell-jensen) |
| Changed in maas: | |
| status: | Triaged → Confirmed |
| Changed in maas: | |
| status: | Confirmed → In Progress |
| Changed in maas: | |
| status: | In Progress → Fix Committed |
| Changed in maas: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
