MidonetL2GatewayTestCase failure

[YAMAMOTO Takashi]

eg. http://logs.openstack.org/88/361488/9/check/gate-networking-midonet-python27-db-ubuntu-xenial/1e8055d/testr_results.html.gz

ft14.3: midonet.neutron.tests.unit.test_extension_l2gateway.MidonetL2GatewayTestCase.test_create_midonet_l2gateway_vlan_with_invalid_seg_id_StringException: Empty attachments:
  pythonlogging:''
  stderr
  stdout

Traceback (most recent call last):
  File "midonet/neutron/tests/unit/test_extension_l2gateway.py", line 78, in setUp
    service_plugins=service_plugins, ext_mgr=l2_gw_mgr)
  File "midonet/neutron/tests/unit/test_midonet_plugin_v2.py", line 105, in setUp
    self.setup_parent(service_plugins=service_plugins, ext_mgr=ext_mgr)
  File "midonet/neutron/tests/unit/test_midonet_plugin_v2.py", line 102, in setup_parent
    MidonetPluginConf.setUp(self, parent_setup)
  File "midonet/neutron/tests/unit/test_midonet_plugin_v2.py", line 75, in setUp
    parent_setup()
  File "/tmp/openstack/neutron/neutron/tests/unit/db/test_db_base_plugin_v2.py", line 133, in setUp
    self.api = router.APIRouter()
  File "/tmp/openstack/neutron/neutron/api/v2/router.py", line 77, in __init__
    ext_mgr = extensions.PluginAwareExtensionManager.get_instance()
  File "/tmp/openstack/neutron/neutron/api/extensions.py", line 670, in get_instance
    service_plugins)
  File "/tmp/openstack/neutron/neutron/api/extensions.py", line 629, in __init__
    self.check_if_plugin_extensions_loaded()
  File "/tmp/openstack/neutron/neutron/api/extensions.py", line 711, in check_if_plugin_extensions_loaded
    extensions=list(missing_aliases))
neutron.common.exceptions.ExtensionsNotFound: Extensions not found: ['l2-gateway'].

[YAMAMOTO Takashi (yamamoto)]

because of the way our l2gw plugin trying to override validate_gwdevice_list,
add_validator method rejects the validator. (correctly)
the problem was exposed by the recent networking-l2gw change to use add_validator method.
(Iece798be0da2ec3ad9e85e1c7672e8b473d1af8f)

[YAMAMOTO Takashi (yamamoto)]

https://review.openstack.org/#/c/375514/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/375514
Committed: https://git.openstack.org/cgit/openstack/networking-midonet/commit/?id=fed00936992e203b6b495734ede6b20dec0c62c3
Submitter: Jenkins
Branch: master

commit fed00936992e203b6b495734ede6b20dec0c62c3
Author: YAMAMOTO Takashi <email address hidden>
Date: Fri Sep 23 22:49:20 2016 +0900

    Fix MidonetL2GatewayTestCase failure

    This fixes an existing hack, which is now making UTs fail, by adding
    another horrible hack which might or might not work. Certainly
    our l2gw plugin needs major rework.

    Closes-Bug: #1625628
    Change-Id: Ib551e3cd46644050abe31417e5ada7ede1d7d37d

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/networking-midonet 3.0.0 release.