neutron

The timeout is not honored in NeutronOVSDBTransaction

Bug #1625604 reported by Hong Hui Xiao
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Hong Hui Xiao

Bug Description

According to [1], the usage of [2] is not appropriate. If timeout > 0, the commit will wait forever.

[1] https://docs.python.org/2/library/queue.html#module-Queue
[2] https://github.com/openstack/neutron/blob/be29217d82cc633bda1a66c2e50612de1e3f7e15/neutron/agent/ovsdb/impl_idl.py#L67

Tags: ovs-lib
Hong Hui Xiao (xiaohhui)
Changed in neutron:
assignee: nobody → Hong Hui Xiao (xiaohhui)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/373231

Changed in neutron:
status: New → In Progress
Armando Migliaccio (armando-migliaccio)
Changed in neutron:
importance: Undecided → Low
Jakub Libosvar (libosvar)
tags: added: mitaka-backport-potential ovs-lib
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/373231
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=a01ca102500cb4705c6c4d8e10180931aa7d5056
Submitter: Jenkins
Branch: master

commit a01ca102500cb4705c6c4d8e10180931aa7d5056
Author: Hong Hui Xiao <email address hidden>
Date: Tue Sep 20 20:15:21 2016 +0800

    Fix wrong use of six.moves.queue.get()

    timeout is not the first positional argument.

    Change-Id: Icd745514adc14730b9179fa7a6dd5c115f5e87a5
    Closes-Bug: #1625604

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
Ihar Hrachyshka (ihar-hrachyshka) wrote :

Not critical for Mitaka, and even potentially unsafe to backport.

tags: removed: mitaka-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/396987

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 10.0.0.0b1

This issue was fixed in the openstack/neutron 10.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (stable/newton)

Change abandoned by ZhaoBo (<email address hidden>) on branch: stable/newton
Review: https://review.openstack.org/396987

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.