Support NSH dataplane protocol

[Igor D.C.]

This RFE is a requirement to achieve https://bugs.launchpad.net/networking-sfc/+bug/1588460, and depends on https://bugs.launchpad.net/networking-sfc/+bug/1587486.

The main changes required are:
- make it possible to select the NSH protocol through the API;
- have NSH protocol support in the SFC OVS agent.

In order to close this bug/RFE, NSH support must be available in upstream Open vSwitch beforehand. Nevertheless, development can be started using the unmerged OVS patches available at https://github.com/yyang13/ovs_nsh_patches.

[cathy Hong Zhang (cathy-h-zhang)]

Current discussion in OVS NSH centers around push/pop for the ethernet header in between the NSH and VXLAN headers. A new patch has been posted for review, which uses the following encap format.
VXLAN Hdr + Ethernet + NSH + Original Frame

Please follow the discussion and consensus of NSH in OVS and make sure code in networking-sfc for supporting NSH is in sync with the latest development in OVS.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/373465

[OpenStack Infra (hudson-openstack)]

Change abandoned by Armando Migliaccio (<email address hidden>) on branch: master
Review: https://review.openstack.org/373465
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[Kevin Benton (kevinbenton)]

This bug has had a related patch abandoned and has been automatically un-assigned due to inactivity. Please re-assign yourself if you are continuing work or adjust the state as appropriate if it is no longer valid.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Kevin Benton (<email address hidden>) on branch: master
Review: https://review.openstack.org/373465
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/510871

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/510871
Committed: https://git.openstack.org/cgit/openstack/networking-sfc/commit/?id=87bf5f3ef9e8dfaad565d5423659928485432622
Submitter: Jenkins
Branch: master

commit 87bf5f3ef9e8dfaad565d5423659928485432622
Author: Igor Duarte Cardoso <email address hidden>
Date: Tue Oct 10 12:10:25 2017 +0000

    Update SFC Encapsulation documentation to NSH

    This patch removes the references to NSH being a future feature,
    clarifies that NSH and MPLS can both be used as correlations in
    any of the scenarios, and adapts some of the examples to use
    NSH instead of MPLS.

    Change-Id: Ia2f8c97365ae33705912752a15351b0ac7f71c5d
    Partial-Bug: #1625278

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/373465
Committed: https://git.openstack.org/cgit/openstack/networking-sfc/commit/?id=ddd77546b7f08097908a5addd8149595515334ac
Submitter: Zuul
Branch: master

commit ddd77546b7f08097908a5addd8149595515334ac
Author: Igor Duarte Cardoso <email address hidden>
Date: Mon Sep 19 15:50:54 2016 +0000

    Support the NSH SFC Encapsulation protocol w/ OVS

    Support NSH SFC Encapsulation protocol when using the OVS driver.
    When NSH is enabled as the correlation for both Port Chain and Port
    Pairs, the NSH SFC Encapsulation protocol will be used alongside
    Ethernet as the transport.

    To clarify, these are all the headers:
    - same compute node : Ethernet + NSH + Original frame
    - across compute nodes : Tunnel stack + Ethernet + NSH + Original frame
    Where Tunnel stack can be VXLAN (Ethernet+IP+UDP+VXLAN).

    This patch builds on top of the improved handling of correlations that
    patch "Support MPLS correlation without SFC Proxy"
    (f4eca7465a841d6503e60b59191ab6d88c87ff45) brought, to specifically
    bring support for the NSH protocol. Service Graphs are compatible.

    This patch also reorganizes test_sfc_driver.py a bit to be easier to
    navigate the tests, since almost all tests were re-implemented in NSH.

    Closes-Bug: #1625278
    Change-Id: Iafbc14f4a6067bc1a1ca472971a862cf740a7e98

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/networking-sfc 6.0.0.0b2 development milestone.