Node tagging workflow doesn't support untagging

Bug #1625264 reported by Ana Krivokapić
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Honza Pokorny

Bug Description

Currently it is not possible to unassign a node from a role.

Changed in tripleo:
importance: Undecided → High
status: New → Triaged
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (master)

Fix proposed to branch: master
Review: https://review.openstack.org/372628

Changed in tripleo:
assignee: nobody → Ana Krivokapić (akrivoka)
status: Triaged → In Progress
Changed in tripleo:
assignee: Ana Krivokapić (akrivoka) → Honza Pokorny (hpokorny)
Changed in tripleo:
milestone: newton-rc2 → ocata-1
tags: added: newton-backport-potential
Changed in tripleo:
milestone: ocata-1 → newton-rc3
Revision history for this message
Emilien Macchi (emilienm) wrote :

Moving it to Ocata 1. It doesn't seem critical for RC3.

Changed in tripleo:
milestone: newton-rc3 → ocata-1
Changed in tripleo:
assignee: Honza Pokorny (hpokorny) → Jiri Tomasek (jtomasek)
Changed in tripleo:
assignee: Jiri Tomasek (jtomasek) → Honza Pokorny (hpokorny)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (master)

Reviewed: https://review.openstack.org/372628
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=30d023702a66c42f00b82854e8d25dfec403bd6f
Submitter: Jenkins
Branch: master

commit 30d023702a66c42f00b82854e8d25dfec403bd6f
Author: Ana Krivokapic <email address hidden>
Date: Mon Sep 19 18:46:00 2016 +0200

    Support node untagging

    The tag_nodes workflow now takes two lists of nodes: nodes to tag, and
    nodes to clear, and of course a role. First, the workflow tags nodes
    with a role, then it clears the other node tags, and finally it updates
    the role count.

    Calling update_node_capability with a value of None will clear the tag
    from the node.

    Change-Id: I1e2988297d56fb4726cd3cae79e79dda889471e1
    Closes-bug: #1625264
    Co-Authored-By: Honza Pokorny <email address hidden>

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/382832

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (stable/newton)

Reviewed: https://review.openstack.org/382832
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=c1efe445493b62ceeb701b5ac90bdc92b498a8a1
Submitter: Jenkins
Branch: stable/newton

commit c1efe445493b62ceeb701b5ac90bdc92b498a8a1
Author: Ana Krivokapic <email address hidden>
Date: Mon Sep 19 18:46:00 2016 +0200

    Support node untagging

    The tag_nodes workflow now takes two lists of nodes: nodes to tag, and
    nodes to clear, and of course a role. First, the workflow tags nodes
    with a role, then it clears the other node tags, and finally it updates
    the role count.

    Calling update_node_capability with a value of None will clear the tag
    from the node.

    Change-Id: I1e2988297d56fb4726cd3cae79e79dda889471e1
    Closes-bug: #1625264
    Co-Authored-By: Honza Pokorny <email address hidden>
    (cherry picked from commit 30d023702a66c42f00b82854e8d25dfec403bd6f)

tags: added: in-stable-newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 5.3.0

This issue was fixed in the openstack/tripleo-common 5.3.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 5.5.0

This issue was fixed in the openstack/tripleo-common 5.5.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.