removing all subports from trunk leaves trunk in DOWN status with openvswitch driver

[Kevin Benton]

Removing all of the subports from a trunk leaves it in the DOWN status rather than it transitioning back to ACTIVE after finishing the wiring as expected.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/372424

[Armando Migliaccio (armando-migliaccio)]

It looks like we forgot to handle this case [1].

[1] https://github.com/openstack/neutron/blob/master/neutron/services/trunk/drivers/openvswitch/agent/ovsdb_handler.py#L267

[Armando Migliaccio (armando-migliaccio)]

https://review.openstack.org/#/c/372750/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/372424
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=88424604016416264804cd8d87c2cebc158c6157
Submitter: Jenkins
Branch: master

commit 88424604016416264804cd8d87c2cebc158c6157
Author: Kevin Benton <email address hidden>
Date: Mon Sep 19 04:26:10 2016 -0700

    Add basic status transition trunk scenario test

    While we wait on a solution to getting 802.1q access inside
    of the guest VM, it is helpful to at least have a test that
    causes the agents to wire up trunk ports and ensure data model
    status transitions happen as expected and that connectivity to
    the trunk port itself is not disrupted by subport operations.

    This test performs those assertions by booting two VMs with
    trunk ports, creating subports on one, asserting statuses,
    moving the subports to the other, and asserting statuses again
    while ensuring connectivity to the VM in between.

    This test uncovered both of the related bugs.

    Related-Bug: #1625136
    Related-Bug: #1625135
    Change-Id: I5f634e3bcc54f5420ba49027b4fb250a13fe277a

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/newton
Review: https://review.openstack.org/374497

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/372750
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=4371ae010a7888220bb67ca9bd423e54c0239fd4
Submitter: Jenkins
Branch: master

commit 4371ae010a7888220bb67ca9bd423e54c0239fd4
Author: Armando Migliaccio <email address hidden>
Date: Mon Sep 19 13:27:30 2016 -0700

    Ensure trunk status is acknowledged during OVS subport operations

    Before this patch, change to trunk status was reported only when
    subports were being added, but not when being removed. This patch
    tweak things to make sure the same happens on subports removal.

    This patch also improves unit coverage for the parts of the code
    affected. In particular the import of oslo_context has been aliased
    to catch errors where context as variable is shadowed by the homonym
    module.

    Closes-bug: #1625135

    Change-Id: I73127d7829c31ca66578eb8f7d76409b36c9dc6d

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/374497
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=ccd58557784913587ec2a72467707bbe2de6833f
Submitter: Jenkins
Branch: stable/newton

commit ccd58557784913587ec2a72467707bbe2de6833f
Author: Kevin Benton <email address hidden>
Date: Mon Sep 19 04:26:10 2016 -0700

    Add basic status transition trunk scenario test

    While we wait on a solution to getting 802.1q access inside
    of the guest VM, it is helpful to at least have a test that
    causes the agents to wire up trunk ports and ensure data model
    status transitions happen as expected and that connectivity to
    the trunk port itself is not disrupted by subport operations.

    This test performs those assertions by booting two VMs with
    trunk ports, creating subports on one, asserting statuses,
    moving the subports to the other, and asserting statuses again
    while ensuring connectivity to the VM in between.

    This test uncovered both of the related bugs.

    Related-Bug: #1625136
    Related-Bug: #1625135
    Change-Id: I5f634e3bcc54f5420ba49027b4fb250a13fe277a
    (cherry picked from commit 88424604016416264804cd8d87c2cebc158c6157)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/374936

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/374936
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=5831c4662026e39dc9d74babb484d02744e2faf7
Submitter: Jenkins
Branch: stable/newton

commit 5831c4662026e39dc9d74babb484d02744e2faf7
Author: Armando Migliaccio <email address hidden>
Date: Mon Sep 19 13:27:30 2016 -0700

    Ensure trunk status is acknowledged during OVS subport operations

    Before this patch, change to trunk status was reported only when
    subports were being added, but not when being removed. This patch
    tweak things to make sure the same happens on subports removal.

    This patch also improves unit coverage for the parts of the code
    affected. In particular the import of oslo_context has been aliased
    to catch errors where context as variable is shadowed by the homonym
    module.

    Closes-bug: #1625135

    Change-Id: I73127d7829c31ca66578eb8f7d76409b36c9dc6d
    (cherry picked from commit 4371ae010a7888220bb67ca9bd423e54c0239fd4)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 9.0.0.0rc2 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 10.0.0.0b1 development milestone.