fuelclient "connect" in 9.1 does not define defaults

Bug #1625104 reported by Dmitry Sutyagin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Won't Fix
High
Georgy Kibardin
Mitaka
Won't Fix
High
Georgy Kibardin

Bug Description

In Timmy project we try to utilize fuelclient library to get data from Fuel. In 9.1 we try to use method "connect" available in fuelclient/__init__.py. In earlier iterations of 9.1 it worked well without passing non-mandatory arguments. Now, however, ( python-fuelclient-9.0.0-1.mos355.noarch ) method "connect" will not set up a working Client object unless either os_username and other non-mandatory parameters are provided, or relevant environment variables are set - this is because this method does not internally use fuelclient_settings.get_settings().

I believe this is a regression and should be fixed. Fuelclient should provide an interface to instantiate Client class with all the default parameters pre-configured.

Tags: area-python
Changed in fuel:
assignee: nobody → Fuel Sustaining (fuel-sustaining-team)
Revision history for this message
Dmitry Sutyagin (dsutyagin) wrote :

I found that the issue originated in Timmy code:
commit https://github.com/adobdin/timmy/commit/a1b43e1cbd435ee2430ba347b574c578f8310130 adds usage of "connect" function and we pass all parameters, however in https://github.com/adobdin/timmy/commit/b052cede2861803c604f76913cf888e01f23dc6f we started to only provide non-default parameters to the "connect" function.

Still I believe that since connect has most parameters as non-mandatory, it should pre-populate mandatory parameters inside Client __init__ to make it work with default values when no parameters are provided from outside.

Changed in fuel:
milestone: none → 10.0
tags: added: area-python
Changed in fuel:
importance: Undecided → High
Changed in fuel:
status: New → Confirmed
assignee: Fuel Sustaining (fuel-sustaining-team) → Georgy Kibardin (gkibardin)
Revision history for this message
Georgy Kibardin (gkibardin) wrote :

It looks like we are in a Zugzwang sitation here - any move would make situation worse by increasing the library API variety.
I would stop making changes here and switch version agnostic clients, such as Timmy to Fuel REST API.

Changed in fuel:
status: Confirmed → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.