[SRU] AUTORCC-generated resources always out-of-date with Ninja

[Elvis Stansvik]

[Impact]

 * people using Ninja to speed up the build, with AUTORCC-generated resources

[Test Case]

 * stuff is not regenerated due to a bug in cmake

[Regression Potential]

 * None

[Other Info]

The upstream bug report is here:

    https://cmake.org/Bug/view.php?id=16049

and was later moved to here:

    https://gitlab.kitware.com/cmake/cmake/issues/16049

It was fixed by Brad King in

    https://gitlab.kitware.com/ben.boeckel/cmake/commit/f6c5958047ee8a9084bf230a6c1acb4801cb2b93

and the fix is in CMake 3.5.2.

I would like to ask what is best: Should I should prepare a debdiff adding this patch to the 3.5.1 package in Xenial and request an SRU? Or is it reasonable to update the Xenial package to 3.5.2 (which is in Yakkety) outright?

[Elvis Stansvik (elvstone)]

Looking at the short list of changes in 3.5.2 [1], perhaps an SRU updating the Xenial package to 3.5.2 might not be completely out of the question?

[1] https://blog.kitware.com/cmake-3-5-2-available-for-download/

[Flames_in_Paradise (ellisistfroh-deactivatedaccount)]

@elvstone: a patch is always easier to apply, if it's applicable. SRU is rather complicated, especially if there are many cross-dependiciens on a package.

Probably xnox (just subscribed has an answer for this much, much better than me.)

[Gianfranco Costamagna (costamagnagianfranco)]

patch fixing the issue

build ongoing at ppa:costamagnagianfranco/costamagnagianfranco-ppa
https://launchpad.net/~costamagnagianfranco/+archive/ubuntu/costamagnagianfranco-ppa

[Gianfranco Costamagna (costamagnagianfranco)]

the debdiff above works with libarchive from updates.
With libarchive from backports an additional patch (Coming from Debian and later releases) is needed.

this debdiff (uploaded on ppa:costamagnagianfranco/boinc) should work

[Martin Pitt (pitti)]

Hello Elvis, or anyone else affected,

Accepted cmake into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/cmake/3.5.1-1ubuntu3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Gianfranco Costamagna (costamagnagianfranco)]

-- Found LibArchive: /usr/lib/x86_64-linux-gnu/libarchive.so (found version "3.2.1")

so far so good.

[Gianfranco Costamagna (costamagnagianfranco)]

@elvis please confirm it too, this works:
cat CMakeLists.txt
find_package(LibArchive)

cmake .

[Elvis Stansvik (elvstone)]

Excellent, thanks a lot. Will verify as soon as I'm back at work tomorrow (missed this email before I left today).

[Elvis Stansvik (elvstone)]

I can confirm this fixes the reported issue.

I can also confirm that LibArchive is found properly with xenial-backports enabled:

estan@newton:~/tmp$ cat CMakeLists.txt
find_package(LibArchive)
estan@newton:~/tmp$ cmake .
.
.
.
-- Found LibArchive: /usr/lib/x86_64-linux-gnu/libarchive.so (found version "3.1.2")
.
.
.
estan@newton:~/tmp$

Thanks a lot for fixing this so fast! No-op builds are now next to instantaneous, even with AUTORCC-generated sources, as they should be :)

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for cmake has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package cmake - 3.5.1-1ubuntu3

---------------
cmake (3.5.1-1ubuntu3) xenial; urgency=medium

  * cherry-pick from upstream to fix Ninja builds (LP: #1624832):
    - debian/patches/f6c5958047ee8a9084bf230a6c1acb4801cb2b93.patch:
  * cherry-pick Debian patch to fix build with libarchive from backports:
    - Make FindLibArchive compatible with libarchive 3.2. (Closes: #828092)
      - Add FindLibArchive_Support_libarchive_3.2.patch

 -- Gianfranco Costamagna <email address hidden> Mon, 26 Sep 2016 19:38:26 +0200

[Flames_in_Paradise (ellisistfroh-deactivatedaccount)]

unsubscribing 'xnox'

big-bow guys - this was pretty fast forward. Sometimes THE internet and it's opportunties still impress me. TKS!

[Elvis Stansvik (elvstone)]

\o/ Thanks!