Do not need run _enable_netfilter_for_bridges() for each new device

Bug #1624648 reported by yujie
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Won't Fix
Undecided
yujie

Bug Description

For a new device, when set security group for it, function prepare_port_filter will be called. Then self._enable_netfilter_for_bridges() will be executed once, which is not needed every time.

    def prepare_port_filter(self, port):
        LOG.debug("Preparing device (%s) filter", port['device'])
        self._remove_chains()
        self._set_ports(port)
        self._enable_netfilter_for_bridges()
        # each security group has it own chains
        self._setup_chains()
        return self.iptables.apply()

We could have a look at _enabled_netfilter_for_bridges first and decide whether to run self._enable_netfilter_for_bridges().

yujie (16189455-d)
Changed in neutron:
assignee: nobody → yujie (16189455-d)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/371912

Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by Yu Jie (<email address hidden>) on branch: master
Review: https://review.openstack.org/371912

Revision history for this message
Rodolfo Alonso (rodolfo-alonso-hernandez) wrote :

Closed due to inactivity. Please feel free to reopen if needed.

Changed in neutron:
status: In Progress → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.