qos rules are not applied to trunk subports

[Armando Migliaccio]

Change [1], introduced a device_owner for trunk sub-ports. However, it was overlooked that device_owner is used by QoS to determine whether to process the port and apply QoS rules [2,3,4].

Right now there is not active coverage that ensures that QoS and Trunk are indeed compatible but as we stand right now, they clearly cannot as the code forbids applying rules to anything whose device_owner starts with 'network:' or 'neutron:'.

We need to figure out a way to solve the conundrum.

[1] https://review.openstack.org/#/c/368289/
[2] https://github.com/openstack/neutron/blob/master/neutron/objects/qos/rule.py#L84

[Armando Migliaccio (armando-migliaccio)]

Mitigation action right now would be to clear the device_owner with neutron port-update, but a more long term solution must be found.

[Armando Migliaccio (armando-migliaccio)]

Kudos to Rawlin for finding it. I am just a messenger.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/371828

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/371829

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/371828
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=ecdf75163527736728e0816ed3ab8e68e0f47b97
Submitter: Jenkins
Branch: master

commit ecdf75163527736728e0816ed3ab8e68e0f47b97
Author: Armando Migliaccio <email address hidden>
Date: Fri Sep 16 15:38:40 2016 -0700

    Change the prefix for trunk subports device_owner

    The choice was poorly made as the 'network:' prefix is used extensively
    in the codebase to identify ports created by the platform itself. Subports
    instead are user created.

    Closes-bug: 1624570

    Change-Id: Ie792a154a6946d0acd5bed322363319e241b1ae7

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/371829
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=5c742bf3ca12ebe2a3fe86406b19b0933cdde605
Submitter: Jenkins
Branch: stable/newton

commit 5c742bf3ca12ebe2a3fe86406b19b0933cdde605
Author: Armando Migliaccio <email address hidden>
Date: Fri Sep 16 15:38:40 2016 -0700

    Change the prefix for trunk subports device_owner

    The choice was poorly made as the 'network:' prefix is used extensively
    in the codebase to identify ports created by the platform itself. Subports
    instead are user created.

    Closes-bug: 1624570

    (cherry picked from commit ecdf75163527736728e0816ed3ab8e68e0f47b97)

    Change-Id: Ie792a154a6946d0acd5bed322363319e241b1ae7

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 9.0.0.0rc2 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 10.0.0.0b1 development milestone.