Mixxx

WaveformMark code is unnecessarily complicated

Bug #1624398 reported by Daniel Schürmann
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Low
Nimit Bhardwaj
Mixxx 2.1.0

Bug Description

This was found when reviewing the band aid fix
https://github.com/mixxxdj/mixxx/pull/1011

WaveformMark::setup() and reset() should be replaced by constructor/destructor code.
The std::move magic should be removed.

See the review comments for details.

Tags: easy
Daniel Schürmann (daschuer)
tags: added: easy
Changed in mixxx:
importance: Undecided → Low
status: New → Confirmed
Sébastien BLAISOT (sblaisot)
summary: - WaveformMark code is unnecissray compilcated
+ WaveformMark code is unnecessarily complicated
Revision history for this message
Nimit Bhardwaj (nimitbhardwaj) wrote :

I am trying to fix this as my first bug patch

Nimit Bhardwaj (nimitbhardwaj)
Changed in mixxx:
assignee: nobody → Nimit Bhardwaj (nimitbhardwaj)
Revision history for this message
Daniel Schürmann (daschuer) wrote :

Thank you for adopting this bug :-)

If you need help just ask.

Make sure you have read this:
http://www.mixxx.org/wiki/doku.php/bugfix_workflow

Revision history for this message
Nimit Bhardwaj (nimitbhardwaj) wrote :

Fix at https://github.com/mixxxdj/mixxx/pull/1083

Revision history for this message
Benis (beenisss) wrote :

Can this be updated to Fix Released?

Revision history for this message
Daniel Schürmann (daschuer) wrote :

Yes, thank you for the reminder.

Changed in mixxx:
milestone: none → 2.1.0
status: Confirmed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/8647

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.